Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow selection of subdetector for track splitting #10356

Merged
merged 3 commits into from Jul 31, 2015

Conversation

hroskes
Copy link
Contributor

@hroskes hroskes commented Jul 24, 2015

Focus track splitting validation on any subdetector by requiring 2 hits there. The default is still BPIX (which was hardcoded before).

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hroskes (Heshy Roskes) for CMSSW_7_6_X.

Allow selection of subdetector for track splitting

It involves the following packages:

Alignment/OfflineValidation

@cmsbuild, @mmusich, @diguida, @cerminar can you please review it and eventually sign? Thanks.
@mschrode, @ghellwig, @frmeier, @mmusich, @tlampen this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mmusich
Copy link
Contributor

mmusich commented Jul 27, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@hroskes
Copy link
Contributor Author

hroskes commented Jul 28, 2015

Is something wrong? The tests are taking longer than usual...

@mmusich
Copy link
Contributor

mmusich commented Jul 28, 2015

@hroskes seems the tests are stuck (at least I cannot access the details)
@cmsbuild could the tests be restarted?

@Dr15Jones
Copy link
Contributor

please test

@hroskes
Copy link
Contributor Author

hroskes commented Jul 30, 2015

@mmusich @cmsbuild
I added 2 more (trivial but useful) commits, hopefully @cmsbuild will reset and be happier this time

@mmusich
Copy link
Contributor

mmusich commented Jul 30, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

cmsbuild added a commit that referenced this pull request Jul 31, 2015
Backport of #10356: Allow selection of subdetector for track splitting
@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jul 31, 2015
Allow selection of subdetector for track splitting
@cmsbuild cmsbuild merged commit 4ca8383 into cms-sw:CMSSW_7_6_X Jul 31, 2015
@hroskes hroskes deleted the track-splitting-subdetectors-76X branch August 25, 2015 19:34
cmsbuild added a commit that referenced this pull request Sep 1, 2015
Backport of #10356: Allow selection of subdetector for track splitting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants