Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger name change in hotline DQM #10359

Merged
merged 2 commits into from Jul 27, 2015
Merged

Trigger name change in hotline DQM #10359

merged 2 commits into from Jul 27, 2015

Conversation

duanders
Copy link
Contributor

Change PFMET trigger names in hotline DQM to reflect removal of HBHE noise filter.

(see https://hypernews.cern.ch/HyperNews/CMS/get/hlt/3977.html)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @duanders (Dustin Anderson) for CMSSW_7_6_X.

Trigger name change in hotline DQM

It involves the following packages:

DQMOffline/Trigger

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
@rociovilar, @trocino, @jhgoh, @battibass this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@perrotta
Copy link
Contributor

@duanders : please notice that according to the hn message you are citing above, there are also the following two paths that need to be updated:

  • (Hotline) HLT_MET250_v1 -> add hltMET250
  • (Hotline) HLT_MET300_v1 -> add hltMET300

Perhaps the message for them was a bit cryptic (sorry...), but it means that for them the hltMETClean250/hltMETClean300 filters do not exist any more, as they were the filters of the now removed noise cleaned met, and they are replaced by hltMET250/hltMET300 respectively.

See lines 78 and 94 in your https://github.com/duanders/cmssw/blob/changehotlinepfmetname/DQMOffline/Trigger/python/hotlineDQM_cfi.py

Moreover: this PR should be subitted also for the data taking releases, i.e. 75X for sure, and perhaps also 74X.

Andrea

@duanders
Copy link
Contributor Author

@perrotta -- thanks for the clarification. I changed the config to reflect the MET filter name changes.

@cmsbuild
Copy link
Contributor

Pull request #10359 was updated. @cmsbuild, @danduggan, @deguio can you please check and sign again.

@deguio
Copy link
Contributor

deguio commented Jul 27, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Jul 27, 2015
@davidlange6 davidlange6 merged commit cb19bc7 into cms-sw:CMSSW_7_6_X Jul 27, 2015
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants