Set MaxADC0 threshold to 9999

[dertexaner]

No description provided.

[cmsbuild]

A new Pull Request was created by @dertexaner for CMSSW_7_4_X.

Set MaxADC0 threshold to 9999

It involves the following packages:

CommonTools/RecoAlgos

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @makortel, @abbiendi, @jhgoh, @ahinzmann this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[abdoulline]

Slava, David,
we need this fix asap in the data taking (74X) to avoid excessive events rejection caused by just a handful of (malfunctioning) channels...

[slava77]

@cmsbuild please test
On Jul 25, 2015 10:39 AM, "abdoulline" notifications@github.com wrote:

Slava, David,
we need this fix asap in the data taking (74X) to avoid excessive events
rejection caused by just a handful of (malfunctioning) channels...

—
Reply to this email directly or view it on GitHub
#10371 (comment).

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: dc61c57
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10371/8901/summary.html

[slava77]

+1

for #10371 dc61c57

• config level change effectively disables a flag in the noise summary flag
• jenkins tests pass and comparisons with the baseline show no differences (MC and run1 data don't have this flag contributing frequently)
• local tests in CMSSW_7_4_X_2015-07-24-2300 /test area test10371/ using run 2 run 251721 doublemu data in /store/data/Run2015B/DoubleMuon/RAW/v1/000/251/721/00000/44C77595-412A-E511-930E-02163E012A2C.root show expected changes:
  • monitored reco products are not changing except for the noise flag itself (fwlite based plots)
  • DQM plots show differences only in jet/met plots that require some noise cleaning. There is a very large number of events that pass and enter the plots now
    

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1