Fixed invalid reference bug when # of tracks exceeds 32767

[istaslis]

The invalid reference bug was fixed using integer instead of short type for keys in track collection. Number of tracks can exceed 32767.

[cmsbuild]

A new Pull Request was created by @istaslis (Stas Lisniak) for CMSSW_7_6_X.

Fixed invalid reference bug when # of tracks exceeds 32767

It involves the following packages:

RecoTracker/FinalTrackSelectors

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @gpetruc, @cerati, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: f9f4f1b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10380/11539/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
797e70e
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10380/11539/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10380/11539/git-merge-result

[slava77]

+1

for #10380 f9f4f1b

• code change is OK
• jenkins tests pass and comparisons with the baseline show no differences
• tested event 9719724 lumi 221 from /store/hidata/HIRun2011/HIMinBiasUPC/RAW/v1/000/182/124/FAD10422-A313-E111-A816-BCAEC532971C.root locally in CMSSW_7_6_X_2015-07-25-2300 /test area test10380/
  • the reconstruction crashes (as expected without this fix)
  • with the fix the hiGeneralTracks part completes OK and produces a collection with 26800

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1