New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove function getProcessParameterSet #10441
Remove function getProcessParameterSet #10441
Conversation
Remove the function getProcessParameterSet from CMSSW. Previous PRs removed most of the places where this function was used. This PR gets a few minor uses that were left in the Framework code. Also removes setProcessParameterSetID and getProcessParameterSetID. This function is being removed because it does not work with SubProcesses and caused threading issues requiring the use of a mutex.
A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_7_6_X. Remove function getProcessParameterSet It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. |
please test |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Remove function getProcessParameterSet
Remove the function getProcessParameterSet
from CMSSW. Previous PRs removed most of the
places where this function was used. This
PR gets a few minor uses that were left in
the Framework code. Also removes setProcessParameterSetID
and getProcessParameterSetID.
This function is being removed because it does not work
with SubProcesses and caused threading issues requiring
the use of a mutex.