Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First integration of Pixel Alignment of large structures in PCL (74X) #10452

Conversation

cerminar
Copy link
Contributor

This PR integrates the alignment of the pixel large structures as a new PCL workflow for Tier0.
There is no code change to any production workflow, only the alca configurations are affected by the changes.

The new workflow has been integrated in the relval 1001 (which now has one more step).

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @cerminar for CMSSW_7_4_X.

First integration of Pixel Alignment of large structures in PCL (74X)

It involves the following packages:

Alignment/CommonAlignment
Alignment/CommonAlignmentAlgorithm
Alignment/CommonAlignmentMonitor
Alignment/CommonAlignmentProducer
Alignment/MillePedeAlignmentAlgorithm
CondFormats/Common
Configuration/EventContent
Configuration/PyReleaseValidation
Configuration/StandardSequences

@diguida, @boudoul, @franzoni, @cerminar, @cmsbuild, @srimanob, @ggovi, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @apfeiffer1, @makortel, @GiacomoSguazzoni, @frmeier, @rovere, @VinInn, @Martin-Grunewald, @tlampen, @mschrode, @cerati, @mmusich, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mmusich
Copy link
Contributor

mmusich commented Jul 29, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-1
Tested at: 1c10e40
When I ran the RelVals I found an error in the following worklfows:
4.22 step2

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

8.0 step3

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step3_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10452/6813/summary.html

@cmsbuild
Copy link
Contributor

Pull request #10452 was updated. @diguida, @danduggan, @boudoul, @franzoni, @cerminar, @fabozzi, @cmsbuild, @srimanob, @ggovi, @mmusich, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10452/8386/summary.html

The workflows 1001.0 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@mmusich
Copy link
Contributor

mmusich commented Sep 28, 2015

+1
contains also backport of #11255

@mmusich
Copy link
Contributor

mmusich commented Sep 28, 2015

Hello,@danduggan, @boudoul, @franzoni, @fabozzi, @srimanob, @ggovi,
can we have this signed again?
Thanks!
M.

@fabozzi
Copy link
Contributor

fabozzi commented Sep 28, 2015

+1

@ggovi
Copy link
Contributor

ggovi commented Sep 29, 2015

+1

@diguida
Copy link
Contributor

diguida commented Sep 30, 2015

@davidlange6 can this be integrated now, as discussed at the ORP?

davidlange6 added a commit that referenced this pull request Sep 30, 2015
…target_maxv1

First integration of Pixel Alignment of large structures in PCL (74X)
@davidlange6 davidlange6 merged commit fd75af5 into cms-sw:CMSSW_7_4_X Sep 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet