Convert PFEGAlgo to use a GlobalCache + GBRForest (74X)

[lgray]

Backport of #10410

[cmsbuild]

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_4_X.

Convert PFEGAlgo to use a GlobalCache + GBRForest (74X)

It involves the following packages:

RecoParticleFlow/PFProducer

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @bachtis this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[lgray]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[lgray]

Apologies, this will fail until #10370 is merged into CMSSW 74X.

[cmsbuild]

-1
Tested at: 2c84bc5
I found an error when building:

>> Compiling  /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_4_X_2015-07-29-2300/src/RecoParticleFlow/PFProducer/src/PFElectronAlgo.cc 
>> Compiling  /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_4_X_2015-07-29-2300/src/RecoParticleFlow/PFProducer/src/PFMuonAlgo.cc 
>> Compiling  /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_4_X_2015-07-29-2300/src/RecoParticleFlow/PFProducer/src/PFPhotonAlgo.cc 
>> Compiling  /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_4_X_2015-07-29-2300/src/RecoParticleFlow/PFProducer/src/PhotonSelectorAlgo.cc 
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_4_X_2015-07-29-2300/src/RecoParticleFlow/PFProducer/src/PFEGammaAlgo.cc: In member function 'float PFEGammaAlgo::EvaluateSingleLegMVA(const pfEGHelpers::HeavyObjectCache_, const PFBlockRef&, const reco::Vertex&, unsigned int)':
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_4_X_2015-07-29-2300/src/RecoParticleFlow/PFProducer/src/PFEGammaAlgo.cc:789:34: error: 'const class GBRForest' has no member named 'GetAdaBoostClassifier'
   mvaValue = hoc->gbrSingleLeg_->GetAdaBoostClassifier(vars);
                                  ^
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_4_X_2015-07-29-2300/src/RecoParticleFlow/PFProducer/src/PFEGammaAlgo.cc: In member function 'float PFEGammaAlgo::calculate_ele_mva(const pfEGHelpers::HeavyObjectCache_, const PFEGammaAlgo::ProtoEGObject&, reco::PFCandidateEGammaExtra&)':
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_4_X_2015-07-29-2300/src/RecoParticleFlow/PFProducer/src/PFEGammaAlgo.cc:2173:28: error: 'const class GBRForest' has no member named 'GetAdaBoostClassifier'
       return hoc->gbrEle_->GetAdaBoostClassifier(vars);


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10474/6844/summary.html

[cmsbuild]

+1
Tested at: c984b5e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10474/5144/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10474/5144/summary.html

There are some workflows for which there are errors in the baseline:
25202.0 step 2
50202.0 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

[cvuosalo]

+1

For #10474 c984b5e

Converting PFEGAlgo to use GlobalCache + GBRForest to reduce memory use. There should be no significant change in monitored quantities. This PR is a 74X backport of #10410, which has already been merged into 76X.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_4_X_2015-07-30-2300 show no significant differences, as expected. Errors in the Jenkins tests are not related to this PR. Memory use reduction was verified in the review of #10410.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[lgray]

@davidlange6 reminder that this needs to go into 74X
Pertinent 76X and 75X relvals check out for relevant quantities.

[davidlange6]

+1