Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MuonSegmentMatcher: add RPC hits, remove MuonServiceProxy dependence #10482

Merged
merged 3 commits into from Aug 6, 2015

Conversation

ptraczyk
Copy link
Contributor

Added a method to MuonSegmentMatcher that performs matching of RPC hits. This is currently not used in standard RECO so no difference in reco output. Also removed the dependence on MuonServiceProxy. This resulted in a bunch of configuration files needing an update, which is also a part of this PR.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ptraczyk (Piotr Traczyk) for CMSSW_7_6_X.

MuonSegmentMatcher: add RPC hits, remove MuonServiceProxy dependence

It involves the following packages:

DQMOffline/JetMET
HLTrigger/Configuration
HLTrigger/HLTanalyzers
RecoMET/METProducers
RecoMuon/MuonIdentification
RecoMuon/TrackingTools

@perrotta, @cmsbuild, @cvuosalo, @fwyzard, @Martin-Grunewald, @deguio, @slava77, @danduggan can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @battibass, @ahinzmann, @abbiendi, @mmarionncern, @jhgoh, @Martin-Grunewald, @bellan, @nhanvtran, @bachtis, @jalimena, @schoef, @mariadalfonso, @trocino, @geoff-smith, @TaiSakuma, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@perrotta
Copy link
Contributor

-1

HLT configurations must be modified in ConfDB, and only after that dumped in the release.
Please add your new parameter in your modified modules using the ParameterSetDescription or, at worst, add it with an existAs() check, so that it does not comply if it is not included in the steering python configs. Then, once your pull request will be merged, the new configurations can be parsed in the HLT menu.

@slava77
Copy link
Contributor

slava77 commented Jul 31, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@slava77
Copy link
Contributor

slava77 commented Jul 31, 2015

+1

for #10482 1240bf7

  • code changes look ok (static analyzer is ok as well)
  • jenkins tests pass and comparisons with the baseline show no differences as expected

@slava77
Copy link
Contributor

slava77 commented Aug 3, 2015

DQM signature is needed here
@deguio could you please check.

@deguio
Copy link
Contributor

deguio commented Aug 6, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Aug 6, 2015
MuonSegmentMatcher: add RPC hits, remove MuonServiceProxy dependence
@cmsbuild cmsbuild merged commit 37e6bec into cms-sw:CMSSW_7_6_X Aug 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants