Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

74x Fireworks: open 3D region from context menu #10487

Merged
merged 2 commits into from Aug 1, 2015

Conversation

alja
Copy link
Contributor

@alja alja commented Jul 30, 2015

@alja
Copy link
Contributor Author

alja commented Jul 30, 2015

+1

@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Jul 30, 2015
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @alja (Alja Mrak-Tadel) for CMSSW_7_4_X.

74x Fireworks: add option to open 3D region from context menu

It involves the following packages:

Fireworks/Core

@cmsbuild, @alja, @Dr15Jones can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

Pull request #10487 was updated. @cmsbuild, @alja, @Dr15Jones can you please check and sign again.

@alja alja changed the title 74x Fireworks: add option to open 3D region from context menu 74x Fireworks: open 3D region from context menu Jul 30, 2015
@alja
Copy link
Contributor Author

alja commented Jul 31, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Aug 1, 2015
74x Fireworks: open 3D region from context menu
@davidlange6 davidlange6 merged commit fbf28da into cms-sw:CMSSW_7_4_X Aug 1, 2015
@alja alja deleted the clip-742 branch May 11, 2017 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants