Final fix for HcalCalPedestals

[diguida]

Following comment by @bsunanda in #10054

[cmsbuild]

A new Pull Request was created by @diguida (Salvatore Di Guida) for CMSSW_7_4_X.

Final fix for HcalCalPedestals

It involves the following packages:

Calibration/HcalAlCaRecoProducers

@cmsbuild, @mmusich, @diguida, @cerminar can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[mmusich]

please test

[mmusich]

currently testing with:

cmsDriver.py HCalCalPedestals -s ALCA:HcalCalPedestal --data --scenario=pp -n 100 --conditions auto:run2_data_FULL --customise=SLHCUpgradeSimulations/Configuration/postLS1Customs.customisePostLS1 --magField AutoFromDBCurrent --processName=USER --filein root://eoscms//eos/cms/store/data/Run2015B/TestEnablesEcalHcal/RAW/v1/000/251/252/00000/82A5CE77-D025-E511-8EC3-02163E0136E2.root

[diguida]

@kodolova this is something you might want to watch as well.

[cmsbuild]

The tests are being triggered in jenkins.

[mmusich]

The test was successful.
It gives:

File ALCARECOHcalCalPedestal.root Events 16393
Branch Name | Average Uncompressed Size (Bytes/Event) | Average Compressed Size (Bytes/Event) 
EventAuxiliary 133.318 30.4614
EventSelections 73.1914 3.04752
BranchListIndexes 18.078 2.27567
EventProductProvenance 16.0756 2.12566

[mmusich]

well. It didn't crash, but it should have some different output.

OutALCARECOHcalCalPedestal_noDrop = cms.PSet(
    SelectEvents = cms.untracked.PSet(
        SelectEvents = cms.vstring('pathALCARECOHcalCalPedestal')
    ),
    outputCommands = cms.untracked.vstring(
    'keep *_gtDigisAlCaMB_*_*',
        'keep HBHERecHitsSorted_hbherecoMB_*_*',
        'keep HORecHitsSorted_horecoMB_*_*',
        'keep HFRecHitsSorted_hfrecoMB_*_*',
        'keep HFRecHitsSorted_hfrecoMBspecial_*_*',
        'keep HBHERecHitsSorted_hbherecoNoise_*_*',
        'keep HORecHitsSorted_horecoNoise_*_*',
        'keep HFRecHitsSorted_hfrecoNoise_*_*')
)

[diguida]

ok, seems that I need another fix...

[diguida]

Issue found: it is a bug in the keep statement (well, I'd rather call it regression...)
Bad, we need to change the output for MinBias too.

Problems are always coming on Friday.

[mmusich]

@diguida yes, since we changed the cloning the keep should be changes as well

[mmusich]

a mininal set would be:

'keep *_gtDigisAlCaPedestals_*_*',
'keep HBHERecHitsSorted_hbherecoPedestals_*_*',
'keep HORecHitsSorted_horecoPedestals_*_*',
'keep HFRecHitsSorted_hfrecoPedestals_*_*'

@kodolova @bsunanda can you comment please? We cannot guess what you need.
For the DIGI do you need all flavours of them?

[cmsbuild]

+1
Tested at: 433dbe5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10498/7499/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
3ab3f08
5bcfccf
56f03a6
0b626fc
60a1b89
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10498/7499/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10498/7499/git-merge-result

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[cmsbuild]

+1
Tested at: 1e2bee8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10498/6897/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10498/5169/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10498/6897/summary.html

[davidlange6]

+1