Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 15GeV cut to electron seeds for HI workflow (75X backport of #10504) #10505

Merged

Conversation

harmonicoscillator
Copy link
Contributor

(cherry picked from commit ffed6f2)

Backport of #10504 to 75X.

Again, this should not change any pp workflows, only HI.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @richard-cms (R. Alex Barbieri) for CMSSW_7_5_X.

Add 15GeV cut to electron seeds for HI workflow (75X backport of #10504)

It involves the following packages:

RecoHI/Configuration

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@MiheeJo, @jazzitup, @echapon, @yenjie, @kurtejung, @istaslis, @mandrenguyen, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Jul 31, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

cvuosalo commented Aug 4, 2015

@richard-cms, @Slava:
This PR seems to eliminate electron GSF tracks in the HI workflow. Is that correct? I thought the 15 GeV cut would only remove fakes. See this plot, among others, in the Jenkins results for 140.53:

all_oldvsnew_runhi2011wf140p53c_log10recogsftracks_electrongsftracks__rereco_obj_p

@harmonicoscillator
Copy link
Contributor Author

This behavior is expected. The electronGsfTracks take the ecalDrivenElectronSeeds as a source (through process.electronCkfTrackCandidates), and so the large reduction in low-pT seeds will also show as a large reduction in electronGsfTracks as their sources disappear.

In a minimum bias sample we expect the number of real electrons above 15GeV to be miniscule.

@hiendoan , do you or @cmkuo have anything to add?

@mandrenguyen
Copy link
Contributor

Workflows 140.4 or 302.0 are ZEE workflows that run the HI reco, which
should be useful for looking at high pT electrons.
Electrons below 15 GeV have never really been used in PbPb.

On 8/5/15 4:49 PM, R. Alex Barbieri wrote:

This behavior is expected. The electronGsfTracks take the
ecalDrivenElectronSeeds as a source (through
process.electronCkfTrackCandidates), and so the large reduction in
low-pT seeds will also show as a large reduction in electronGsfTracks
as their sources disappear.

In a minimum bias sample we expect the number of real electrons above
15GeV to be miniscule.

@hiendoan https://github.com/hiendoan , do you or @cmkuo
https://github.com/cmkuo have anything to add?


Reply to this email directly or view it on GitHub
#10505 (comment).


Matthew Nguyen
Chargé de Recherche
LLR-Ecole Polytechnique
91128 Palaiseau FRANCE

+33 1 69 33 55 65

@harmonicoscillator
Copy link
Contributor Author

I ran the 140.4 workflow that @mandrenguyen suggested for 20 events and compared before/after this PR the recoGsfTracks:

original:
https://twiki.cern.ch/twiki/pub/CMS/PhotonAnalyses2015/recoGsfTracks_electronGsfTracks__RECO.obj.pt_originalf.gif

After cut:
https://twiki.cern.ch/twiki/pub/CMS/PhotonAnalyses2015/recoGsfTracks_electronGsfTracks__RECO.obj.ptf.gif

You can see that only the low-pT tracks are removed, as we expect (and want!).

@cvuosalo
Copy link
Contributor

cvuosalo commented Aug 5, 2015

+1

For #10505 16a59d9

Adding 15 GeV cut to electron seeds for HI to reduce fake rate for jets. There should be no change for pp workflows. The 76X version of this PR, #10504, includes validation plots from the developers.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-07-31-1100 show no significant differences for pp workflows. For the HI workflow 140.53, electron GSF tracks disappear, which, as discussed above, is the desired and intended effect. Otherwise there are very small differences as expected from the reduction in fake electrons and jets.
An extended test of 100 events for workflow 140.53 against baseline CMSSW_7_5_X_2015-07-31-1100 also shows the expected loss of low-pT electrons and also very small differences expected from the reduction in fake electrons and jets. Plots of the electron loss are below.

all_testpr10505vsorig_runhi2011wf140p53c_log10recopfcandidates_particleflowegamma__rereco_obj_p
all_testpr10505vsorig_runhi2011wf140p53c_log10recopfcandidates_particleflowegamma__rereco_obj_pt
all_testpr10505vsorig_runhi2011wf140p53c_recopfcandidates_particleflowegamma__rereco_obj_eta

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Aug 6, 2015
Add 15GeV cut to electron seeds for HI workflow (75X backport of #10504)
@cmsbuild cmsbuild merged commit c068edd into cms-sw:CMSSW_7_5_X Aug 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants