Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes for data reco processing with 25ns #10518

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Aug 2, 2015

  • to determine bunch spacing in data in PFClusterEMEnergyCorrector and EcalUncalibRecHitWorkerMultiFit
    • use run 253000 as a maximum with 50 ns if auto-selection is enabled
    • fixup/add manual bunch spacing setting is the auto-selection is disabled
  • in RecoTLR (still using local customs implementation for run2 data processing)
    • remove CCC override-to-OFF in prompt and express customizations
    • add customise_DQM to the common customs (already in 75X/76X)
    • add customiseL1RecoForStage1 for stage1 unpackers and l1extra to use calo stage1
    • add customiseDataRun2Common_25ns (since I couldn't figure out how to more transparently set a default to 25ns and then be able to customize that to 50ns);
    • NB: the customiseDataRun2Common can still be used for Run2015B data processing as suggested in a few HN posts
    • add customiseDataRun2Common_50nsRunsAfter253000 function (it's in the name!) to force 50ns settings for runs after 253000, if we need it
    • remove outdated planBTracking
  • add ppRun2at50ns scenario in T0 processing setup

tested in CMSSW_7_4_X_2015-08-01-1100
Configs for T0 tested

  • with run_CfgTest.log
  • by running ppRun2 and ppRun2at50ns with prompt reco (RunPromptReco.py) on /store/data/Run2015B/DoubleMuon/RAW/v1/000/251/721/00000/44C77595-412A-E511-930E-02163E012A2C.root.

Changes are as expected, appear only in the run2 T0 workflow:

  • there are less tracks with less hits and the cluster charge on track shows a cutoff due to CCC (many plots downstream change as well consistent with CCC enabling)
    251721_tob_ontrack
    all_sign74xfor25ns-test50nsvsorig_doublemuon251721c_recotracks_generaltracks__reco_obj_found
  • L1 plots changed quite a bit
    251721_l1cenjet
    251721_l1taujet
    probably the only suspicious ones are based on HF: they are empty now
    251721_l1hf
  • no change is observed in running ppRun2at50ns and ppRun2 workflows on the run 251721 since the default bunch spacing detection in both cases falls to 50 ns setup.

In addition, tested the machinery with a run after 253000 /store/data/Run2015B/MinimumBias/RAW/v1/000/253/020/00000/BA19E72A-5B37-E511-B00F-02163E0134B5.root (the run is cosmics and has no tracker or muons included)
As expected,

  • ppRun2at50ns and ppRun2 show differences in the ECAL hit energies (previously constrained to 0 values now yield some results, as expected from the change in the multifit configuration)
    all_sign74xfor25ns-test50nsvssign74xfor25ns-test25ns_minimumbias253020c_ecalrechitssorted_ecalrechit_ecalrechitseb_reco_obj_obj_energy
  • the baseline and ppRun2at50ns in this case produce identical results in the reco products (there is no tracker in this run).
    • stage1 is not in this run and as a result, all related DQM plots are empty ... I'm assuming we will not be switching stage1 on and off once this all starts working next week @mulhearn @deguio @danduggan

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2015

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_7_4_X.

changes for data reco processing with 25ns

It involves the following packages:

Configuration/DataProcessing
RecoLocalCalo/EcalRecProducers
RecoParticleFlow/PFClusterProducer

@cmsbuild, @cvuosalo, @franzoni, @davidlange6, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @mmarionncern, @argiro, @Martin-Grunewald, @lgray, @bachtis this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor Author

slava77 commented Aug 2, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2015

The tests are being triggered in jenkins.

@slava77
Copy link
Contributor Author

slava77 commented Aug 3, 2015

+1

for #10518 dc5da96

  • based on the pre-PR submission tests
  • jenkins tests pass and comparisons with the baseline show no differences

@rovere
Copy link
Contributor

rovere commented Aug 4, 2015

FYI.
@VinInn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants