Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMSHLT-508 74X PR to update DQM modules #10520

Merged
merged 1 commit into from Aug 11, 2015
Merged

Conversation

mrcarver
Copy link
Contributor

@mrcarver mrcarver commented Aug 2, 2015

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2015

A new Pull Request was created by @mrcarver for CMSSW_7_4_X.

CMSHLT-508 74X PR to update DQM modules

It involves the following packages:

HLTriggerOffline/SUSYBSM

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Aug 5, 2015

please test

@deguio
Copy link
Contributor

deguio commented Aug 5, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2015

-1
Tested at: 9cffd4c
When I ran the RelVals I found an error in the following worklfows:
140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log

50202.0 step3

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10520/6974/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@parbol
Copy link
Contributor

parbol commented Aug 7, 2015

Hi I would like to understand whether we need to change something here. Having a look at the log files I didn't see anything that was particularly pointing to our code. I only see the PFMET invalid collection in the HotlineDQM for the first workflow and the Trigger Summary not being available in the second one.

@Martin-Grunewald
Copy link
Contributor

The problem seems to be

%MSG
attempting to stop a stopped timer
05-Aug-2015 11:58:16 CEST  Closed file root://eoscms//eos/cms/store/relval/CMSSW_7_4_0_pre7/RelValMinBias_13/GEN-SIM/MCRUN2_74_V7-v1/00000/802A09CA-EEB6-E411-A76A-0025905B85B2.root?svcClass=default

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@parbol
Copy link
Contributor

parbol commented Aug 11, 2015

Dear experts,

We are a bit lost about the evolution of this PR. Can you please explain whether and action is required from us? We're not 100% sure about the reason why this is failing, if it is failing. It's important that we finish this PR since this is blocking the introduction of a SUSY signal trigger in the menu. You can count with all our resources to fix it, but we need some help to understand what's going on. Thanks

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Aug 11, 2015
CMSHLT-508 74X PR to update DQM modules
@cmsbuild cmsbuild merged commit c758754 into cms-sw:CMSSW_7_4_X Aug 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants