Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add combMVA to bTag DQM #10529

Merged
merged 2 commits into from Aug 15, 2015
Merged

Add combMVA to bTag DQM #10529

merged 2 commits into from Aug 15, 2015

Conversation

pablodecm
Copy link
Contributor

combMVA will be one of the POG supported taggers for Run 2 possible changes
between releases have to be monitored. Because the bTagGenericAnalysisBlock config
is used only a python configuration has to be modified.

I run several tests (FullSim, Data and FastSim) with the runTheMatrix.py script and everything
seem to work as expected.

This changes have to be backported to 75X and 74X as soon as possible.

combMVA will be one of the POG supported taggers for Run 2 possible changes
between releases have to be monitored. Because the bTagGenericAnalysisBlock config
is used only a python configuration has to be modXified.
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2015

A new Pull Request was created by @pablodecm (Pablo de Castro) for CMSSW_7_6_X.

Add combMVA to bTag DQM

It involves the following packages:

DQMOffline/RecoB

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
@ferencek, @acaudron, @rociovilar, @pvmulder, @imarches this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Aug 12, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@deguio
Copy link
Contributor

deguio commented Aug 12, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

-1
Tested at: d1532c1
The relvals timed out after 2 hours.

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10529/7187/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@deguio
Copy link
Contributor

deguio commented Aug 14, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Aug 15, 2015
@cmsbuild cmsbuild merged commit c1663c3 into cms-sw:CMSSW_7_6_X Aug 15, 2015
pablodecm added a commit to pablodecm/cmssw that referenced this pull request Sep 22, 2015
cmsbuild added a commit that referenced this pull request Nov 6, 2015
Add combMVA to DQM (cherry-picking PR #10529)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants