Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning runthematrix76 x #10559

Merged
merged 4 commits into from Aug 4, 2015
Merged

Conversation

boudoul
Copy link
Contributor

@boudoul boudoul commented Aug 4, 2015

This PR is intended to synchronize runthematrix with 75X (see PR #10558)
It removes the option magfield added by mistake by @srimanob
Some check should be further done with the baseDataSetRelease but testing already as it is now

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2015

A new Pull Request was created by @boudoul (boudoul) for CMSSW_7_6_X.

Cleaning runthematrix76 x

It involves the following packages:

Configuration/PyReleaseValidation

@cmsbuild, @srimanob, @boudoul, @franzoni can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@boudoul
Copy link
Contributor Author

boudoul commented Aug 4, 2015

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2015

@boudoul
Copy link
Contributor Author

boudoul commented Aug 4, 2015

removed duplicate

@boudoul
Copy link
Contributor Author

boudoul commented Aug 4, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2015

Pull request #10559 was updated. @cmsbuild, @srimanob, @boudoul, @franzoni can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2015

davidlange6 added a commit that referenced this pull request Aug 4, 2015
@davidlange6 davidlange6 merged commit d91cf8c into cms-sw:CMSSW_7_6_X Aug 4, 2015
@srimanob
Copy link
Contributor

srimanob commented Aug 4, 2015

Sorry, I don't follow up the comment that "It removes the option magfield added by mistake by me."
@boudoul , why don't we need magField for FastSim?
However, this line is proposed by FastSim group,
https://github.com/lveldere/cmssw/blob/8dd97e3968c6b2bdd0047e3b8a16c556c4a2d388/Configuration/PyReleaseValidation/python/relval_steps.py#L613

@lveldere Could you please comment?

In addition, this line is also in 74X,
https://github.com/cms-sw/cmssw/blob/CMSSW_7_4_X/Configuration/PyReleaseValidation/python/relval_steps.py#L615

@boudoul
Copy link
Contributor Author

boudoul commented Aug 5, 2015

@srimanob and @lveldere : from CMSSW_7_4_3 and CMSSW_7_5_0_pre5 : the magfield is read from the GT and not anymore from xml, see here (*) for reference - If it is also in runthematrix74X also we should remove it from there too.

(*) https://hypernews.cern.ch/HyperNews/CMS/get/swDevelopment/3214.html

@srimanob
Copy link
Contributor

srimanob commented Aug 5, 2015

OK, Thanks. I will fix 74X.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants