Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

750 tracking particles PreMixing fixes #10569

Merged

Conversation

mdhildreth
Copy link
Contributor

Modify merging of tracking particles to update references between new copies of TrackingParticles and TrackingVertices. Set "validation" mode to be default for first PreMixing stage in RelVals so TrackingParticles are produced automatically.

@mdhildreth
Copy link
Contributor Author

Waiting for validation from DPG folks. Don't merge just yet!

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2015

A new Pull Request was created by @mdhildreth for CMSSW_7_5_X.

750 tracking particles PreMixing fixes

It involves the following packages:

Configuration/PyReleaseValidation
SimGeneral/DataMixingModule

@civanch, @boudoul, @srimanob, @mdhildreth, @cmsbuild, @franzoni can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlange6
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2015

@davidlange6
Copy link
Contributor

@cmsbuild, please test

@mdhildreth, @makortel - is this ready now?

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2015

Pull request #10569 was updated. @civanch, @boudoul, @srimanob, @mdhildreth, @cmsbuild, @franzoni, @davidlange6 can you please check and sign again.

@makortel
Copy link
Contributor

makortel commented Aug 9, 2015

@davidlange6 I think this is still work in progress (e.g. I understood from @mdhildreth that he would some further developments for muons that I don't see here). But for tracking validation the following works

# Re-produce premixed pileup events
runTheMatrix.py -i all -l 250199.0

# Produce configurations only for subsequent steps 
# Apply the customisation only to step3 (yes, --apply has to be 2)
runTheMatrix.py -i all -l 250202.0 -j 0 --command="--customise SimGeneral/DataMixingModule/customiseForPremixingInput.customiseForPremixingInput" --apply 2
cd 250202.0*
cat >> step2_DIGIPREMIX_S2_DATAMIX_L1_DIGI2RAW_HLT_RAW2DIGI_L1Reco.py <<EOF
process.mixData.input.fileNames = ["file:$PWD/../250199.0_PREMIXUP15_PU25+PREMIXUP15_PU25/step1.root"]
process.FEVTDEBUGHLToutput.outputCommands.extend([
    "keep TrackingParticles_mixData_*_*",
    "keep TrackingVertexs_mixData_*_*",
    'keep *_*_StripDigiSimLink_*',
    'keep *_*_PixelDigiSimLink_*'
])
EOF
cmsRun step2_DIGIPREMIX_S2_DATAMIX_L1_DIGI2RAW_HLT_RAW2DIGI_L1Reco.py
cmsRun step3_RAW2DIGI_L1Reco_RECO_EI_VALIDATION_DQM.py
cmsRun step4_HARVESTING.py 

I have only tested with handful of events and not compared the results to classical mixing, but I can see from MTV output that it gets pileup TrackingParticles and e.g. fake rates have qualitatively similar structure as with classical mixing.

Important points

  • premixed pileup events need to be reproduced (with DIGIPREMIX:pdigi_valid, as the default should be after this PR)
  • step2 event content needs modifications (FEVTDEBUGHLT does not contain PREMIXRAWEventContent?)
  • step3 needs --customise SimGeneral/DataMixingModule/customiseForPremixingInput.customiseForPremixingInput

The step3 output will be full of messages like

*** WARNING in MuonAssociatorByHitsHelper::associateRecoToSim: no matching PSimHit found for this reco::Track !
*** WARNING in CSCHitAssociator::associateCSCHitId - CSC layer 604018234 has no DigiSimLinks ! 

for whose I understood @mdhildreth should have further developments (not yet fully working).

@cmsbuild
Copy link
Contributor

Pull request #10569 was updated. @danduggan, @boudoul, @srimanob, @cmsbuild, @franzoni, @deguio, @davidlange6 can you please check and sign again.

@deguio
Copy link
Contributor

deguio commented Sep 14, 2015

please test

@deguio
Copy link
Contributor

deguio commented Sep 14, 2015

+1
DQM slightly touched

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

davidlange6 added a commit that referenced this pull request Sep 16, 2015
…xingFixes

750 tracking particles PreMixing fixes
@davidlange6 davidlange6 merged commit a55deef into cms-sw:CMSSW_7_5_X Sep 16, 2015
@ghost ghost mentioned this pull request Jan 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants