Fix plugins in HLTrigger/JetMET

[davidlange6]

move plugins into plugins directory (with other plugins) as not to rely on luck that exactly one plugin library links against HLTrigger/JetMET/src

[cmsbuild]

A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_7_4_X.

Fix plugins in HLTrigger/JetMET

It involves the following packages:

HLTrigger/JetMET

@Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[davidlange6]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.

[davidlange6]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

Pull request #10582 was updated. @perrotta, @cmsbuild, @danduggan, @Martin-Grunewald, @deguio, @fwyzard can you please check and sign again.

[Dr15Jones]

@smuzaffar @davidlange6 Maybe we should start scanning lib*.so for plugins and issuing errors if they are found?

[smuzaffar]

I agree. Is there any symbol which one can look in the lib*.so?

On 8/5/2015 2:54 PM, Chris Jones wrote:

@smuzaffar https://github.com/smuzaffar @davidlange6
https://github.com/davidlange6 Maybe we should start scanning
lib*.so for plugins and issuing errors if they are found?

—
Reply to this email directly or view it on GitHub
#10582 (comment).

[cmsbuild]

+1
Tested at: fe497d2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10582/193536/summary.html

[Dr15Jones]

@smuzaffar I don't believe a symbol exists. It is possible to make a simple executable that would return a particular value if a plugin was found in a loaded library.

[cmsbuild]

+1
Tested at: fe497d2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10582/6983/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10582/193536/summary.html

There are some workflows for which there are errors in the baseline:
135.4 step 1
1306.0 step 2
9.0 step 3
1330.0 step 2
25.0 step 3
1001.0 step 2
25202.0 step 2
50202.0 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10582/6983/summary.html

There are some workflows for which there are errors in the baseline:
135.4 step 1
1306.0 step 2
9.0 step 3
1330.0 step 2
25.0 step 3
1001.0 step 2
25202.0 step 2
50202.0 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request