Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factorise PreSplitting configuration from InitialStep #10584

Conversation

rovere
Copy link
Contributor

@rovere rovere commented Aug 5, 2015

Completely factorize PreSplitting from InitialStep configuration, so that they can be tuned independently. Fix order of python import logic. No regression expected.

See also #10580 e #10583

…that they can be tuned independently. Fix order of python import logic. No regression expected.
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2015

A new Pull Request was created by @rovere (Marco Rovere) for CMSSW_7_5_X.

Factorise PreSplitting configuration from InitialStep

It involves the following packages:

RecoTracker/IterativeTracking

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @VinInn, @mschrode, @istaslis, @gpetruc, @cerati, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Aug 5, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2015

@cvuosalo
Copy link
Contributor

cvuosalo commented Aug 8, 2015

+1

For #10584 409c3dc

For Tracking, factorizing PreSplitting configuration from the InitialStep. This code improvement to facilitate tuning should have no effect on monitored quantities. The 74X and 76X versions of this PR, #10583 and #10580, have already been approved by Reco.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-08-05-1100 show no significant differences, as expected. Correct inclusion of the code change into the config was verified for #10580.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 1, 2015
…Estimator_75X

Factorise PreSplitting configuration from InitialStep
@cmsbuild cmsbuild merged commit de24a50 into cms-sw:CMSSW_7_5_X Sep 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants