Fixed behavior in QjetsAdder

[sidnarayanan]

QjetsAdder would crash if more than one jet was reclustered out of the original jet. Now it returns a volatility of -1.

[cmsbuild]

A new Pull Request was created by @sidnarayanan (Sid Narayanan) for CMSSW_7_6_X.

Fixed behavior in QjetsAdder

It involves the following packages:

RecoJets/JetProducers

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @ahinzmann, @TaiSakuma, @yslai, @nhanvtran, @schoef, @mariadalfonso this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

@cmsbuild please test

@sidnarayanan if you have a specific workflow configuration where the crash happens, please provide so that we have a record

[cmsbuild]

The tests are being triggered in jenkins.

[sidnarayanan]

@slava77 This snippet of code will crash on a fraction of events, where PFJetsCHS15 are CA R=1.5 jets.

process.Qjets15 = QJetsAdder.clone(
    src = cms.InputTag("PFJetsCHS15"),
    jetRad = cms.double(1.5),
    jetAlgo = cms.string(algoLabel),
    cutoff = cms.double(.1),
    ntrial = cms.int32(25)
)

Please let me know if you need more information.

[cmsbuild]

-1
Tested at: 1260a0a
When I ran the RelVals I found an error in the following worklfows:
25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
----- Begin Fatal Exception 05-Aug-2015 19:03:31 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
RootEmbeddedFileSequence no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

4.22 step1

DAS Error

4.53 step1

DAS Error

140.53 step1

DAS Error

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10590/6994/summary.html

[slava77]

@cmsbuild please test
maybe less das errors this time

[cmsbuild]

The tests are being triggered in jenkins.

[slava77]

+1

for #10590 1260a0a

• the code change looks reasonable
• the code is not running in any standard workflows
• jetnkins test compilation and unit tests are OK [the requested re-testing is a bit redundant]

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[cmsbuild]

+1
Tested at: 1260a0a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10590/6999/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10590/6999/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1