Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pileup summary info slimmer for MiniAOD #10592

Merged
merged 1 commit into from Aug 8, 2015

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Aug 5, 2015

Per a line of investigation in the flashgg group I took a look at slimming the PileupSummaryInfos.
The results are quite nice when keeping the details only for the in-time bunch crossing, and then zeroing out all the vectors of track pTs and such for all others.

Bunch spacing, number of interactions, and true pileup mean are kept for all crossings.

You can see the benchmarking info here:
cms-analysis/flashgg#269 (comment)

It would seem a good idea just to include this in MiniAOD already since it saves 4.5kb/ev on TTBar 25ns (calculated from 100 events). Can only get better for more complex things.

@gpetruc @arizzi

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2015

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_5_X.

Pileup summary info slimmer for MiniAOD

It involves the following packages:

PhysicsTools/PatAlgos

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
@rappoccio, @imarches, @ahinzmann, @acaudron, @mmarionncern, @jdolen, @nhanvtran, @schoef, @ferencek, @gpetruc, @mariadalfonso, @pvmulder, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@lgray
Copy link
Contributor Author

lgray commented Aug 5, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10592/5274/summary.html

There are some workflows for which there are errors in the baseline:
50202.0 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

@lgray
Copy link
Contributor Author

lgray commented Aug 6, 2015

@sethzenz @musella You may be interested to follow.

@monttj
Copy link
Contributor

monttj commented Aug 6, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Aug 8, 2015
Pileup summary info slimmer for MiniAOD
@cmsbuild cmsbuild merged commit 9a91912 into cms-sw:CMSSW_7_5_X Aug 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants