back port modified and newly added relval workflows from 75X and 76X #10615
Conversation
|
A new Pull Request was created by @hengne (Hengne Li) for CMSSW_7_1_X. back port modified and newly added relval workflows from 75X and 76X It involves the following packages: Configuration/Generator @vciulli, @covarell, @boudoul, @franzoni, @thuer, @cmsbuild, @srimanob, @bendavid can you please review it and eventually sign? Thanks. |
|
@cmsbuild , please test |
|
The tests are being triggered in jenkins. |
|
-1 |
|
hi @hengne , you should modify the file relval_pileup which is still expecting the string QQH1352T_Tauola (while it is defined now as QQH1352T ) you might have to change other input file too (maybe relval_standard?) |
|
Also line 511 should not be modified: In das , the dataset is /RelValQQH1352T_Tauola/CMSSW_7_1_0_pre7-PRE_STA71_V3-v1/GEN-SIM , which your change it will try to call RelValQQH1352T/CMSSW_7_1_0_pre7-PRE_STA71_V3-v1/GEN-SIM which doesn't exist and will fail |
|
The change line 403 should be a typo, please fix |
|
About the change lline 389 : This comment may also be true for the modifications for ZpEE_2250_13INPUT and ZpTT_2250_13INPUT , please check |
…GEN-SIMs exist yet for them.
|
@boudoul thanks, also relval_premix.py should be modified at the same On Fri, Aug 7, 2015 at 9:09 AM, boudoul notifications@github.com wrote:
|
|
@boudoul thanks, fixed. On Fri, Aug 7, 2015 at 9:21 AM, boudoul notifications@github.com wrote:
|
|
Dear @hengne , before testing we should look at the content - I will do as soon as I can - Less than a working day can certainly not always be achievable, no need to ping twice a day - Please lower a bit your expectation |
|
@boudoul Please trigger the test, there is nothing hurt by start the automatic test, the test also takes time. You can check the codes at anytime before you sign it. It has been there a day ago, if you trigger the test yesterday, we can already know if there is any technical bugs, for which i can already fix it before wasting your time to look at it. |
|
Tests are resources, and they will anyway fail due to the DAS ongoing issues |
|
@cmsbuild , please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
+1 |
|
+1 |
cmsbuild
added
fully-signed
pdmv-approved
and removed
pdmv-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
@davidlange6 Could this one be merged? It has been there ONLY orp-pending for 5 days! Thanks! |
|
Hi @hengne , for 71X a discussion at ORP is done (once per week) for the PR to be merged for the next 71 releases which are produced on request, so please no need ping the offline team in github, thanks |
|
+1 |
…0_relval_testedForMerge back port modified and newly added relval workflows from 75X and 76X
Back port modified and newly added workflows from 75X and 76X, especially for GEN-SIM generation for relval workflows.
All fullSim noPU workflows for 13TeV are tested using latest IB.