Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PixBarrelEfficiency #10624

Merged
merged 3 commits into from Sep 1, 2015
Merged

PixBarrelEfficiency #10624

merged 3 commits into from Sep 1, 2015

Conversation

fioriNTU
Copy link
Contributor

@fioriNTU fioriNTU commented Aug 7, 2015

Fix to Pix Barrel Hit Efficiency plots

@fioriNTU
Copy link
Contributor Author

@cmsbuild can you please assign this to dqm?

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fioriNTU for CMSSW_7_4_X.

PixBarrelEfficiency

It involves the following packages:

DQM/SiPixelCommon
DQM/SiPixelMonitorClient
DQM/SiPixelMonitorDigi
DQM/SiPixelMonitorTrack

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
@threus this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@danduggan
Copy link
Contributor

please test

On Tue, Aug 25, 2015 at 11:41 AM, cmsbuild notifications@github.com wrote:

A new Pull Request was created by @fioriNTU https://github.com/fioriNTU
for CMSSW_7_4_X.

PixBarrelEfficiency

It involves the following packages:

DQM/SiPixelCommon
DQM/SiPixelMonitorClient
DQM/SiPixelMonitorDigi
DQM/SiPixelMonitorTrack

@cmsbuild https://github.com/cmsbuild, @danduggan
https://github.com/danduggan, @deguio https://github.com/deguio can
you please review it and eventually sign? Thanks.
@threus https://github.com/threus this is something you requested to
watch as well.
You can sign-off by replying to this message having '+1' in the first line
of your reply.
You can reject by replying to this message having '-1' in the first line
of your reply.
If you are a L2 or a release manager you can ask for tests by saying
'please test' in the first line of a comment.
@Degano https://github.com/degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of
your comment.


Reply to this email directly or view it on GitHub
#10624 (comment).

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@danduggan
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 1, 2015
@cmsbuild cmsbuild merged commit a994b62 into cms-sw:CMSSW_7_4_X Sep 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants