PixelBarrelEfficiency75

[fioriNTU]

Fix for pixel barrel hit efficiency plots

[cmsbuild]

A new Pull Request was created by @fioriNTU for CMSSW_7_5_X.

PixelBarrelEfficiency75

It involves the following packages:

DQM/SiPixelMonitorClient
DQM/SiPixelMonitorTrack

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
@threus this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[deguio]

please test

[deguio]

+1
provided it passes the tests.
I don't see the corresponding fix for 74. don't you want to backport the fix there as well?
F.

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[cmsbuild]

+1
Tested at: b764ede
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10632/7310/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10632/7310/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1

[fioriNTU]

Hi Federico,
sorry for late reply, I am just back from holidays. Actually I submitted
a PR also for 74X with the same fix, looking in github
(#10624) the fix is in PR 10624.
Could you check please?

Ciao,
FF

Il 14/08/2015 17.44, Federico De Guio ha scritto:

+1
provided it passes the tests.
I don't see the corresponding fix for 74. don't you want to backport
the fix there as well?
F.

—
Reply to this email directly or view it on GitHub
#10632 (comment).

---

Questa e-mail è stata controllata per individuare virus con Avast antivirus.
https://www.avast.com/antivirus