Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix for Run2015A+B 0T luminous region centroid positions (75X) #10640

Merged

Conversation

diguida
Copy link
Contributor

@diguida diguida commented Aug 8, 2015

This is due to conflicting changes by #10384 (in particular commit a43a039 ) and #10435 (in particular commit b4701d4 ) for IOMC/EventVertexGenerators/python/VtxSmearedParameters_cfi.py.

This does not jeopardise the 3.8T vertex smearing definitions, but the 0T position of the luminous region centroid was left artificially in the same position, while we know that the 150 um shift in X is due to magnetic field effects on the beam.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2015

A new Pull Request was created by @diguida (Salvatore Di Guida) for CMSSW_7_5_X.

Hotfix for Run2015A+B 0T luminous region centroid positions (75X)

It involves the following packages:

IOMC/EventVertexGenerators

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@diguida
Copy link
Contributor Author

diguida commented Aug 8, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2015

@civanch
Copy link
Contributor

civanch commented Aug 9, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Aug 12, 2015
…+B_75X

Hotfix for Run2015A+B 0T luminous region centroid positions (75X)
@cmsbuild cmsbuild merged commit ce79f94 into cms-sw:CMSSW_7_5_X Aug 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants