Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run "high level muon reconstruction" for heavy ions #10657

Merged
merged 2 commits into from Aug 17, 2015

Conversation

echapon
Copy link
Contributor

@echapon echapon commented Aug 10, 2015

75X equivalent of #10654

@slava77
Copy link
Contributor

slava77 commented Aug 10, 2015

@cmsbuild please test

@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Aug 10, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @echapon (Emilien Chapon) for CMSSW_7_5_X.

Run "high level muon reconstruction" for heavy ions

It involves the following packages:

RecoHI/Configuration
RecoHI/HiEgammaAlgos
RecoHI/HiMuonAlgos

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@MiheeJo, @jazzitup, @richard-cms, @yenjie, @kurtejung, @istaslis, @mandrenguyen, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #10657 a6a0bdb

Adding high-level muon reconstruction for Heavy Ions. #10654 is the 76X version of this PR, and it has already been approved by Reco.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-08-10-1100 show the added muons for HI workflow 140.53 but no other significant differences. A timing test for #10654 shows no significant change in muon processing time.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Aug 17, 2015
Run "high level muon reconstruction" for heavy ions
@cmsbuild cmsbuild merged commit b7d4583 into cms-sw:CMSSW_7_5_X Aug 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants