Make missing consumes calls an exception #10661
Conversation
This makes it an exception when a module has not declared the products it gets with a consumes function call. Previous to this it just resulted in an error being printed out. Fixed HcalDigisValidation which had recently added a getByLabel without a consumes call. Also fixed two Framework unit tests that also had problems with consumes calls. This has been tested to not cause problems in the IB by scanning all the log files of a recent IB for the error message. Framework unit tests also pass. While this should cause no IB test failures, there probably will be failures of other code not tested in the IBs which has not been migrated to declare the products it consumes.
|
A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_7_6_X. Make missing consumes calls an exception It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones, @deguio, @danduggan can you please review it and eventually sign? Thanks. |
|
please test |
|
+1 |
|
The tests are being triggered in jenkins. |
cmsbuild
added
core-approved
tests-started
and removed
core-pending
tests-pending
labels
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
I was running DtCalib aclareco as a part of "PromptReco" setup and I see DTCalibMuonSelection missing a consumes. |
|
I added the consumes migration for DTCalibMuonSelection |
|
please test |
|
The tests are being triggered in jenkins. |
cmsbuild
added
alca-pending
comparison-pending
core-pending
tests-pending
and removed
tests-approved
labels
|
Pull request #10661 was updated. @smuzaffar, @diguida, @danduggan, @cerminar, @cmsbuild, @Dr15Jones, @deguio, @mmusich can you please check and sign again. |
|
+1 |
cmsbuild
added
core-approved
tests-started
and removed
core-pending
tests-pending
labels
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Make missing consumes calls an exception
This makes it an exception when a module has
not declared the products it gets with a consumes
function call. Previous to this it just resulted
in an error being printed out.
Fixed HcalDigisValidation which had recently added
a getByLabel without a consumes call. Also fixed
two Framework unit tests that also had problems with
consumes calls.
This has been tested to not cause problems in the
IB by scanning all the log files of a recent
IB for the error message. Framework unit tests
also pass.
While this should cause no IB test failures, there
probably will be failures of other code not tested
in the IBs which has not been migrated to declare
the products it consumes.