Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking HLT validation cleanup #10688

Merged
merged 6 commits into from Aug 16, 2015

Conversation

makortel
Copy link
Contributor

This PR cleans up the HLT tracking validation configurations, and adds a flag to MultiTrackValidator to control if the min(DeltaR) should be calculated wrt. a single reference collection (old behaviour), or wrt. each track collection to itself (the behaviour needed here). This allows merging the four MTV instances into a single one, which further makes the summary plots meaningful (now they contain all the monitored HLT track collections instead of a single one). Add a DQMGenericClient to produce the efficiency, fake rate etc. for the summary plots as in offline validation.

Tested in CMSSW_7_6_X_2015-07-29-2300, expecting following changes only

  • MTV summary and simulation plots contain all monitored HLT track collections separately instead of being merged to a single bin
  • summary plots contain now efficiency, fake rate etc.

@rovere @VinInn @mtosi

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_6_X.

Tracking HLT validation cleanup

It involves the following packages:

HLTriggerOffline/Common
Validation/RecoTrack

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @rovere, @VinInn, @cerati, @wmtford, @istaslis, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Aug 14, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@deguio
Copy link
Contributor

deguio commented Aug 14, 2015

by cloning the postProcessorTrack a number of histograms is added in the harvesting step. is this needed/wanted (apart from the summary ones you mention)?

@makortel
Copy link
Contributor Author

I would say yes, we want to keep the HLT instance in sync with the offline one also for harvesting step (sorry for forgotting to mention these). Their input histograms were anyway already produced. (and if it turns out that something is not needed/wanted, we should remove these input histograms from MTV too from the HLT instance).

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Aug 16, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Aug 16, 2015
@cmsbuild cmsbuild merged commit 69140a1 into cms-sw:CMSSW_7_6_X Aug 16, 2015
@makortel makortel deleted the trackingHLTValidationCleanup branch October 20, 2016 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants