New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking HLT validation cleanup #10688
Tracking HLT validation cleanup #10688
Conversation
…or for each input collection itself
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_6_X. Tracking HLT validation cleanup It involves the following packages: HLTriggerOffline/Common @cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
by cloning the postProcessorTrack a number of histograms is added in the harvesting step. is this needed/wanted (apart from the summary ones you mention)? |
I would say yes, we want to keep the HLT instance in sync with the offline one also for harvesting step (sorry for forgotting to mention these). Their input histograms were anyway already produced. (and if it turns out that something is not needed/wanted, we should remove these input histograms from MTV too from the HLT instance). |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Tracking HLT validation cleanup
This PR cleans up the HLT tracking validation configurations, and adds a flag to MultiTrackValidator to control if the min(DeltaR) should be calculated wrt. a single reference collection (old behaviour), or wrt. each track collection to itself (the behaviour needed here). This allows merging the four MTV instances into a single one, which further makes the summary plots meaningful (now they contain all the monitored HLT track collections instead of a single one). Add a DQMGenericClient to produce the efficiency, fake rate etc. for the summary plots as in offline validation.
Tested in CMSSW_7_6_X_2015-07-29-2300, expecting following changes only
@rovere @VinInn @mtosi