Fix phase1TkCustoms for recent changes to defaults

[mark-grimes]

This updates the Phase1 tracker customisations for recent changes to the default sequence, mostly coming in with #10373. At the moment the Phase1 workflows don't even run with --command="--no_exec", you'll get the error:

customising the process with cust_2017 from SLHCUpgradeSimulations/Configuration/combinedCustoms
Traceback (most recent call last):
  <snip>
  File "/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc493/cms/cmssw/CMSSW_7_6_X_2015-08-10-2300/python/SLHCUpgradeSimulations/Configuration/phase1TkCustoms.py", line 222, in customise_Reco
    process.reconstruction_fromRECO.remove(process.initialStepSelector)
AttributeError: 'Process' object has no attribute 'initialStepSelector'

...and no config file is generated.

Note that the Phase1 workflows (e.g. runTheMatrix.py -w upgrade -l 10000.0) don't actually run at the moment - this PR just allows the config files to be generated with the --no_exec command. Pull request #10353 will get the workflows as far as reco.

I don't expect this to be the final version of the customisation functions, they will probably need a big overhaul[*] but at least this lets runTheMatrix run. Having said that I've tried to keep the changes sensible.

[*] probably replaced with an upgrade era, the creation of which is actually how I ran into this problem.

@boudoul, @atricomi

[cmsbuild]

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_7_6_X.

Fix phase1TkCustoms for recent changes to defaults

It involves the following packages:

SLHCUpgradeSimulations/Configuration

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[mark-grimes]

please test

Should only affect Phase1, which isn't in the standard list of tests but doesn't hurt to check.

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

-1
Tested at: 0dde715
When I ran the RelVals I found an error in the following worklfows:
25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
----- Begin Fatal Exception 11-Aug-2015 19:33:04 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
RootEmbeddedFileSequence no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

50202.0 step2

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step2_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log
----- Begin Fatal Exception 11-Aug-2015 19:33:08 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
RootEmbeddedFileSequence no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

4.22 step1

DAS Error

4.53 step1

DAS Error

140.53 step1

DAS Error

1000.0 step1

DAS Error

1001.0 step1

DAS Error

1003.0 step1

DAS Error

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10694/7150/summary.html

[mark-grimes]

All unrelated DAS errors as far as I can see.

[boudoul]

thanks @mark-grimes for having taken care of this

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: 0dde715
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10694/7377/summary.html