Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move slimmedAddPileupInfo to miniAOD_customizeMC (75X) #10749

Merged

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Aug 13, 2015

backport of #10748

@lgray
Copy link
Contributor Author

lgray commented Aug 13, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_5_X.

Move slimmedAddPileupInfo to miniAOD_customizeMC (75X)

It involves the following packages:

PhysicsTools/PatAlgos

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
@rappoccio, @imarches, @ahinzmann, @acaudron, @mmarionncern, @jdolen, @nhanvtran, @schoef, @ferencek, @gpetruc, @mariadalfonso, @pvmulder, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@lgray
Copy link
Contributor Author

lgray commented Aug 13, 2015

@slava77

@lgray
Copy link
Contributor Author

lgray commented Aug 14, 2015

@cmsbuild please test

@lgray
Copy link
Contributor Author

lgray commented Aug 14, 2015

@slava77 looks like this one got in a funny state. Please kick when possible.

@lgray
Copy link
Contributor Author

lgray commented Aug 14, 2015

@smuzaffar Hey, could you please manually start tests on this one in jenkins? It seems to have gotten into a bad state.

@smuzaffar
Copy link
Contributor

In this case, the test which were started yesterday
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/lastFailedBuild/consoleFull
failed due to build machine failure. So jenkins was not able to update the status and cms-bot thinks that test are still running that is why it is not started them again.

I am started them now,

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@lgray
Copy link
Contributor Author

lgray commented Aug 14, 2015

@smuzaffar thanks a lot!

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@monttj
Copy link
Contributor

monttj commented Aug 14, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Aug 20, 2015
Move slimmedAddPileupInfo to miniAOD_customizeMC (75X)
@cmsbuild cmsbuild merged commit f04d61a into cms-sw:CMSSW_7_5_X Aug 20, 2015
@cmsbuild cmsbuild merged commit e78fefb into cms-sw:CMSSW_7_5_X Aug 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants