New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BeamSpot] fit 1D projections of PV distribution to get initial values for 3D fit parameters #10781
[BeamSpot] fit 1D projections of PV distribution to get initial values for 3D fit parameters #10781
Conversation
…the 1D projections
@cmsbuild please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @rmanzoni (Riccardo Manzoni) for CMSSW_7_5_X. [BeamSpot] fit 1D projections of PV distribution to get initial values for 3D fit parameters It involves the following packages: RecoVertex/BeamSpotProducer @diguida, @cvuosalo, @cerminar, @cmsbuild, @slava77, @mmusich can you please review it and eventually sign? Thanks. |
+1 Changing the initial values of the primary vertex fit. The 76X version of this PR, #10780, has already been approved by Reco. The code changes are satisfactory. Jenkins tests against baseline CMSSW_7_5_X_2015-08-14-1100 show very small changes in PV fit results, but none of these differences are significant. See #10780 for an example plot of the small changes in the fit results. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
…ed3DFit [BeamSpot] fit 1D projections of PV distribution to get initial values for 3D fit parameters
back porting #10780