Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BeamSpot] fit 1D projections of PV distribution to get initial values for 3D fit parameters #10781

Merged

Conversation

rmanzoni
Copy link
Contributor

back porting #10780

@slava77
Copy link
Contributor

slava77 commented Aug 14, 2015

@cmsbuild please test

@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Aug 14, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rmanzoni (Riccardo Manzoni) for CMSSW_7_5_X.

[BeamSpot] fit 1D projections of PV distribution to get initial values for 3D fit parameters

It involves the following packages:

RecoVertex/BeamSpotProducer

@diguida, @cvuosalo, @cerminar, @cmsbuild, @slava77, @mmusich can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @rovere, @VinInn, @cerati, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #10781 4d421de

Changing the initial values of the primary vertex fit. The 76X version of this PR, #10780, has already been approved by Reco.

The code changes are satisfactory. Jenkins tests against baseline CMSSW_7_5_X_2015-08-14-1100 show very small changes in PV fit results, but none of these differences are significant. See #10780 for an example plot of the small changes in the fit results.

@diguida
Copy link
Contributor

diguida commented Aug 14, 2015

+1
for 4d421de

The correspondent version in 76X #10780 has already been approved by AlCa.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Aug 17, 2015
…ed3DFit

[BeamSpot] fit 1D projections of PV distribution to get initial values for 3D fit parameters
@cmsbuild cmsbuild merged commit 4b1fe81 into cms-sw:CMSSW_7_5_X Aug 17, 2015
@rmanzoni rmanzoni deleted the CMSSW_7_5_X_stabilized3DFit branch August 19, 2015 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants