New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefetch mayConsumes to avoid deadlocks #10795
Conversation
We must prefetch even data products which are mayConsumes in order to avoid deadlocks for the case where another thread has locked a resource needed by the unscheduled module. This will go away once resources are released when a module calls 'Event::getBy*'.
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_6_X. Prefetch mayConsumes to avoid deadlocks It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. |
please test |
+1 |
@davidlange6 This should fix the deadlocks in the CMSSW_7_6_THREADED_X IB RelVals. |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Prefetch mayConsumes to avoid deadlocks
We must prefetch even data products which are mayConsumes in order
to avoid deadlocks for the case where another thread has locked a
resource needed by the unscheduled module. This will go away once
resources are released when a module calls 'Event::getBy*'.