condformats_serialization_generate.py: fix include paths and fail on serious issues

[davidlt]

• The script itself uses libClang for parsing C++ source files, thus we
  must use include files as seen by Clang. Note, this still points to GNU
  C++ standard library in GCC package, but there are special headers which
  are compiler specific, those are picked up from Clang package.
• Print severity level names instead numbers.
• Fail if there are 'Error' or/and 'Fatal' level diagnotic messages.
• Remove obsolete ignore rules. They should not be triggered as long as
  include paths and arguments passed to libClang are valid.
• This should resolve issue where get_statement could return None,
  because compiler couldn't do a correct job due to missing/wrong
  include paths or/and arguments.
• Required for Clang 3.7.0.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

[davidlt]

I requested some of this before. I finally bumped into this while testing Clang 3.7.0. We have to make sure that header is compilable with Clang and do not proceed if there are serious issues otherwise this has impact on translation unit. In particular case, Clang was not able to provide SourceRange, because one of SourceLocation was not valid. Because script never checks for get_statement() return this will cause the whole thing to crash and burn. Worked on the current Clang we have which is somewhere between 3.5.0 and 3.6.0 and Clang 3.7.0 RC2.

[cmsbuild]

A new Pull Request was created by @davidlt for CMSSW_7_6_X.

condformats_serialization_generate.py: fix include paths and fail on serious issues

It involves the following packages:

CondFormats/Serialization

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@apfeiffer1 this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[davidlt]

Note, Jenkins testing is running, but it's useless because SCRAM or SCRAM generated Makefile does not check for modifications in condformats_serialization_generate.py, thus it does not checkout CondFormats. Test it locally by checking out git cms-addpkg CondFormats.

[cmsbuild]

+1
Tested at: 31c837d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10837/7424/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10837/7424/summary.html

[davidlt]

ping^1

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1