Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear the event selector in a thread safe manner #1085

Merged

Conversation

Dr15Jones
Copy link
Contributor

Moved the sentry used to clear the event selector at the end of each event processing to be within the mutex. This makes sure all updates on that object are done in the same critical section.

Moved the sentry used to clear the event selector at the end of each event processing to be within the mutex. This makes sure all updates on that object are done in the same critical section.
@Dr15Jones
Copy link
Contributor Author

+1

All framework unit tests pass

@nclopezo
Copy link
Contributor

I started the tests yesterday on Jenkins, and it seems to be stuck in the unit tests, you can see the logs here:

https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc481/908/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests.

@nclopezo
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests.

ktf added a commit that referenced this pull request Oct 17, 2013
Multithreaded framework -- Clear the event selector in a thread safe manner
@ktf ktf merged commit a6043d1 into cms-sw:CMSSW_7_0_THREADED_X Oct 17, 2013
@Dr15Jones Dr15Jones deleted the clearEventSelectorThreadSafely branch October 17, 2013 16:46
epalencia added a commit to epalencia/cmssw that referenced this pull request Apr 3, 2023
Added option to trigger on loose HMT showers in EMTF (backport of 41185)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants