migrate RPCPointProducer to a global::EDProducer (76x) #10936

fwyzard · 2015-08-25T01:16:02Z

migrate RPCPointProducer to a global::EDProducer

…eir own files in the process: - rename ObjectMap to DTObjectMap - rename ObjectMapCSC to CSCObjectMap - merge multiple copies

- change all configuration parameters into const members - initialise them in the member initializer list - remove unused methods and member variables - change into a global::EDProducer

cmsbuild · 2015-08-25T01:16:11Z

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_6_X.

migrate RPCPointProducer to a global::EDProducer (76x)

It involves the following packages:

HLTrigger/Configuration
RecoLocalMuon/RPCRecHit

@perrotta, @cmsbuild, @cvuosalo, @slava77, @Martin-Grunewald, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @bellan, @jalimena, @geoff-smith, @jhgoh this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

fwyzard · 2015-08-25T01:16:22Z

rebase #10927 on top of CMSSW_7_6_X

fwyzard · 2015-08-25T01:16:34Z

@cmsbuild please test

fwyzard · 2015-08-25T01:18:42Z

RecoLocalMuon/RPCRecHit/src/CSCObjectMap.cc

+
+std::set<RPCDetId> const& CSCObjectMap::getRolls(CSCStationIndex index) const
+{
+  // FIXME


here I have kept the same behaviour as the previous implementation, which allows for NOT finding the given index in the map; a muon expert should check that this is the intended behaviour.

cmsbuild · 2015-08-25T01:21:09Z

The tests are being triggered in jenkins.

fwyzard · 2015-08-25T01:22:06Z

@cmsbuild please test

cmsbuild · 2015-08-25T01:26:10Z

Pull request #10936 was updated. @perrotta, @cvuosalo, @slava77, @Martin-Grunewald, @deguio, @fwyzard, @danduggan can you please check and sign again.

cmsbuild · 2015-08-25T03:22:05Z

-1

Tested at: 78e33af
I found errors in the following addon tests:

cmsRun /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-08-24-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Aug 25 05:15:50 2015-date Tue Aug 25 05:05:45 2015 s - exit: 16640
cmsRun /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-08-24-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Aug 25 05:09:32 2015-date Tue Aug 25 05:06:38 2015 s - exit: 16640

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10936/7626/summary.html

cmsbuild · 2015-08-25T04:26:21Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10936/7626/summary.html

…guration

cmsbuild · 2015-08-25T18:57:53Z

Pull request #10936 was updated. @cmsbuild, @cvuosalo, @danduggan, @deguio, @slava77 can you please check and sign again.

cmsbuild · 2015-08-25T21:21:20Z

+1
Tested at: a0c1b57
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10936/7644/summary.html

cmsbuild · 2015-08-25T22:07:00Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10936/7644/summary.html

slava77 · 2015-08-26T18:08:13Z

HLTrigger/Configuration/python/customizeHLTforCMSSW.py

@@ -119,14 +119,24 @@ def customiseFor10418(process):
       setattr(process.hltBSoftMuonMu5L3,'algorithmMaskContains', cms.vstring())
    return process

+# migrate RPCPointProducer to a global::EDProducer (PR #10927)
+def customiseFor10927(process):


does this number "10972" (instead of 10936 or 10935) matter?

slava77 · 2015-08-26T19:06:06Z

after looking at the code, I don't think additional changes have to be made in this PR

slava77 · 2015-08-26T19:10:43Z

+1

for #10936 a0c1b57

changes in the code are OK for the purpose of making it thread-friendly
this code is running only in HLT at this point
jenkins tests pass and comparisons with baseline (full DQM or reco fwlite comparisons) show no differences as expected

fwyzard · 2015-08-27T08:19:21Z

tracked at #10964

danduggan · 2015-08-27T15:24:22Z

+1

cmsbuild · 2015-08-27T15:27:23Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

…part2 migrate RPCPointProducer to a global::EDProducer (76x)

fwyzard added 4 commits August 25, 2015 03:10

move CSCObjectMap, CSCStationIndex, DTObjectMap, DTStationIndex to th…

e94aa04

…eir own files in the process: - rename ObjectMap to DTObjectMap - rename ObjectMapCSC to CSCObjectMap - merge multiple copies

move DTObjectMap and CSCObjectMap to the EventSetup

9843140

RPCPointProducer: change into a global::EDProducer

8afbcee

- change all configuration parameters into const members - initialise them in the member initializer list - remove unused methods and member variables - change into a global::EDProducer

fix #include syntax

e2346ae

cmsbuild added this to the Next CMSSW_7_6_X milestone Aug 25, 2015

cmsbuild added reconstruction-pending hlt-pending pending-signatures tests-pending orp-pending comparison-pending labels Aug 25, 2015

fwyzard mentioned this pull request Aug 25, 2015

migrate RPCPointProducer to a global::EDProducer #10927

Closed

fwyzard reviewed Aug 25, 2015
View reviewed changes

cmsbuild added dqm-pending tests-started and removed tests-pending labels Aug 25, 2015

cmsbuild added tests-rejected and removed tests-started labels Aug 25, 2015

cmsbuild added comparison-available and removed comparison-pending labels Aug 25, 2015

add CSCObjectMapESProducer and DTObjectMapESProducer to the HLT confi…

4e2ef9c

…guration

cmsbuild added hlt-approved tests-pending comparison-pending labels Aug 25, 2015

cmsbuild added tests-started and removed tests-pending labels Aug 25, 2015

cmsbuild added tests-approved and removed tests-started labels Aug 25, 2015

cmsbuild added comparison-available and removed comparison-pending labels Aug 25, 2015

slava77 reviewed Aug 26, 2015
View reviewed changes

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Aug 26, 2015

fwyzard mentioned this pull request Aug 27, 2015

migrate modules used by the HLT menu to multithreading (76x) #10964

Closed

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Aug 27, 2015

davidlange6 added a commit that referenced this pull request Aug 28, 2015

Merge pull request #10936 from fwyzard/migrate_to_multithreading_76x_…

a711127

…part2 migrate RPCPointProducer to a global::EDProducer (76x)

davidlange6 merged commit a711127 into cms-sw:CMSSW_7_6_X Aug 28, 2015

fwyzard mentioned this pull request Aug 28, 2015

more cleanup of RecoLocalMuon/RPCRecHit #11000

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

migrate RPCPointProducer to a global::EDProducer (76x) #10936

migrate RPCPointProducer to a global::EDProducer (76x) #10936

fwyzard commented Aug 25, 2015

cmsbuild commented Aug 25, 2015

fwyzard commented Aug 25, 2015

fwyzard commented Aug 25, 2015

fwyzard Aug 25, 2015

cmsbuild commented Aug 25, 2015

fwyzard commented Aug 25, 2015

cmsbuild commented Aug 25, 2015

cmsbuild commented Aug 25, 2015

cmsbuild commented Aug 25, 2015

cmsbuild commented Aug 25, 2015

cmsbuild commented Aug 25, 2015

cmsbuild commented Aug 25, 2015

slava77 Aug 26, 2015

slava77 commented Aug 26, 2015

slava77 commented Aug 26, 2015

fwyzard commented Aug 27, 2015

danduggan commented Aug 27, 2015

cmsbuild commented Aug 27, 2015

migrate RPCPointProducer to a global::EDProducer (76x) #10936

migrate RPCPointProducer to a global::EDProducer (76x) #10936

Conversation

fwyzard commented Aug 25, 2015

cmsbuild commented Aug 25, 2015

fwyzard commented Aug 25, 2015

fwyzard commented Aug 25, 2015

fwyzard Aug 25, 2015

Choose a reason for hiding this comment

cmsbuild commented Aug 25, 2015

fwyzard commented Aug 25, 2015

cmsbuild commented Aug 25, 2015

cmsbuild commented Aug 25, 2015

cmsbuild commented Aug 25, 2015

cmsbuild commented Aug 25, 2015

cmsbuild commented Aug 25, 2015

cmsbuild commented Aug 25, 2015

slava77 Aug 26, 2015

Choose a reason for hiding this comment

slava77 commented Aug 26, 2015

slava77 commented Aug 26, 2015

fwyzard commented Aug 27, 2015

danduggan commented Aug 27, 2015

cmsbuild commented Aug 27, 2015