Fix DQM/PhysicsHWW by just ignoring jets with invalid parameters (76x) #10941
Conversation
|
A new Pull Request was created by @dmitrijus (Dmitrijus) for CMSSW_7_6_X. Fix DQM/PhysicsHWW by just ignoring jets with invalid parameters (76x) It involves the following packages: DQM/PhysicsHWW @cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks. |
Fixes (silences) exceptions in relvals for 76x. See diff. This module needs to be rewritten (or removed). The code currently has no maintainter and it's in a pretty bad state. In this particular case both hww.pfjets_p4 and hww.pfjets_JEC are filled separately (and can have different sizes), even though array index represents the same jet. This is definetly an error.
dmitrijus
force-pushed
the
hww_rebase_75x
branch
from
29cfbca
to
6d6c952
Compare
|
Pull request #10941 was updated. @cmsbuild, @danduggan, @deguio can you please check and sign again. |
|
please test |
|
+1 |
|
The tests are being triggered in jenkins. |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
Fix DQM/PhysicsHWW by just ignoring jets with invalid parameters (76x)
Fixes (silences) exceptions in relvals for 76x.
https://hypernews.cern.ch/HyperNews/CMS/get/relval/3992.html
https://hypernews.cern.ch/HyperNews/CMS/get/relval/3999.html
This module needs to be rewritten (or removed).
The code currently has no maintainer and it's in a pretty bad state.
In this particular case both hww.pfjets_p4 and hww.pfjets_JEC are filled
separately (and can have different sizes), even though
array index represents the same jet. This is definitely an error.