Thread Safety: Remove unneeded state from TriggerResultsBasedEventSelector #10951
Conversation
|
A new Pull Request was created by @wmtan for CMSSW_7_6_X. Thread Safety: Remove unneeded state from TriggerResultsBasedEventSelector It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. |
|
please test |
|
The tests are being triggered in jenkins. |
| bool match() | ||
| { | ||
| return eventSelector_.acceptEvent(*product_); | ||
| bool match(TriggerResults const& product) { |
There was a problem hiding this comment.
Not yet. Work is needed in class "EventSelector" before "match", and a whole bunch of other functions can be made const. That is the goal, but we are not there yet.
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
+1 |
…Cleanup Thread Safety: Remove unneeded state from TriggerResultsBasedEventSelector
This is one more step toward a thread safe global::OutputModule base class. The related classes NamedEventSelector and TriggerResultsBasedEventSelector had unnecessary data members that could be modified during the processing an event. This PR removes the unnecessary data. It also, for maintainability and clarity, changes some iterator loops to range based for loops.
Note: Thread safety work also needs to be done on class EventSelector. That will be a separate PR.