Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate modules used by the HLT menu to multithreading (AlCa) (75x) #10969

Merged
merged 4 commits into from Sep 2, 2015
Merged

migrate modules used by the HLT menu to multithreading (AlCa) (75x) #10969

merged 4 commits into from Sep 2, 2015

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Aug 27, 2015

backport #10957 to 75x

@fwyzard
LaserAlignmentEventFilter: change into a global::EDFilter
1316cf1 
  - change all configuration parameters into const members
  - initialise them in the member initializer list
  - remove unnecessary parameters
  - remove unnecessary caching of EventSetup products
  - remove unused methods and member variables
  - remove usage of exceptions in the FED check loop
  - change into a global::EDFilter
@fwyzard
IPTCorrector: change into a global::EDProducer
7889e90 
  - change all configuration parameters into const members
  - initialise them in the member initializer list
  - remove unused methods and member variables
  - change into a global::EDProducer
@fwyzard
IsolatedPixelTrackCandidateProducer: change into a stream::EDProducer
2a8bfa3 
  - change most configuration parameters into const members
  - initialise them in the member initializer list
  - change into a stream::EDProducer
@fwyzard
IsolatedEcalPixelTrackCandidateProducer: change into a global::EDProd…
4734d39 
…ucer

  - change all configuration parameters into const members
  - initialise them in the member initializer list
  - remove unused methods
  - change into a global::EDProducer
@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Aug 27, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_5_X.

migrate to modules used by the HLT menu multithreading (AlCa) (75x)

It involves the following packages:

Alignment/LaserAlignment
Calibration/HcalIsolatedTrackReco

@cmsbuild, @mmusich, @diguida, @cerminar can you please review it and eventually sign? Thanks.
@mschrode, @ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

This was referenced Aug 27, 2015
Closed
Closed
@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 27, 2015

tracked at #10965

@mmusich
Copy link
Contributor

mmusich commented Aug 27, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 4734d39
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10969/7682/summary.html

@mmusich
Copy link
Contributor

mmusich commented Aug 27, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10969/7682/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 2, 2015
@cmsbuild
Merge pull request #10969 from fwyzard/migrate_to_multithreading_75x_…
ffa4c20 
…AlCa

migrate to modules used by the HLT menu multithreading (AlCa) (75x)
@cmsbuild cmsbuild merged commit ffa4c20 into cms-sw:CMSSW_7_5_X Sep 2, 2015
@fwyzard fwyzard changed the title migrate to modules used by the HLT menu multithreading (AlCa) (75x) migrate modules used by the HLT menu to multithreading (AlCa) (75x) Sep 2, 2015
@fwyzard fwyzard mentioned this pull request Sep 21, 2015
Merged
@fwyzard fwyzard deleted the migrate_to_multithreading_75x_AlCa branch September 23, 2015 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved comparison-available fully-signed tests-approved
Projects
None yet
Milestone
CMSSW_7_5_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fwyzard @cmsbuild @mmusich @davidlange6