Fix bug in JetPlusTrackCorrections_cff.py: add JetVertexExtender

[kodolova]

JetPlusTrack correction practically does not work and return calojet energy only without adding ak4JetExtender to the python configurator.

[cmsbuild]

A new Pull Request was created by @kodolova (kodolova) for CMSSW_7_6_X.

Fix bug in JetPlusTrackCorrections_cff.py: add JetVertexExtender

It involves the following packages:

RecoJets/JetPlusTracks

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @ahinzmann, @TaiSakuma, @jdolen, @nhanvtran, @schoef, @mariadalfonso this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

please remove the commented out line, unless there's a good reason for it to be here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

Pull request #10977 was updated. @cmsbuild, @cvuosalo, @slava77 can you please check and sign again.

[cmsbuild]

+1
Tested at: 1a594f2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10977/7689/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
56e9288
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10977/7689/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10977/7689/git-merge-result

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10977/7689/summary.html

[slava77]

Hi Olga,

I see that ak4JetExtenderJPT is added (it produces a JetExtendedAssociation::Container), but nothing is reading its data in the jobs we are running and it's data is not saved.
Either this PR is not complete (a keep statement is needed) or I'm missing something.

Please clarify.

[slava77]

Just to clarify the status from my side: I'm not planning to sign off on addition of a module which doesn't make any used products.
So, I'm waiting for feedback.

[kodolova]

Hi Slava, you are right. Only ak4JetTracksAssociatorAtCaloFace is needed to be added.
I removed JetExtender and checked that JPT correction is ok. sorry for inconvenience.

[cmsbuild]

Pull request #10977 was updated. @cmsbuild, @cvuosalo, @slava77 can you please check and sign again.

[slava77]

Hi Olga,
ak4JetTracksAssociatorAtCaloFace is already defined and is running prior to JetPlusTrackZSPCorJetAntiKt4 as a part of
ak4JTA https://github.com/cms-sw/cmssw/blob/CMSSW_7_6_X/RecoJets/JetAssociationProducers/python/ak4JTA_cff.py

In which workflow did you see an issue?
Is it in the full RECO sequence or just some smaller JPT analysis job?

[cmsbuild]

The jenkins tests job failed, please try again.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/7758/console

[slava77]

@cmsbuild please test

... the last one failed with

ssl.SSLError: _ssl.c:493: The handshake operation timed out
Build step 'Execute shell' marked build as failure

[cmsbuild]

The tests are being triggered in jenkins.

[kodolova]

Hi Slava, I found the issue when I run JPT reconstruction over AODSIM trying to derive L2L3 corrections.

[slava77]

On 8/31/15 12:12 PM, kodolova wrote:

Hi Slava, I found the issue when I run JPT reconstruction over AODSIM
trying to derive L2L3 corrections.

Olga, thank you for the clarification.
It makes sense to be an issue in a setup like that
and your fix is appropriate.

—
Reply to this email directly or view it on GitHub
#10977 (comment).

[cmsbuild]

+1
Tested at: 7d9a2b5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10977/7759/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10977/7759/summary.html

[slava77]

+1

for #10977 7d9a2b5

• the change is good for applications starting with JetPlusTrackCorrectionsAntiKt4 sequence (full reco sequence is not affected because the missing module is present in ak4JTA included elsewhere
• jenkins tests pass and comparisons with baseline show no relevant differences
  • DQM plots show differences in PU ID variables, which seem random and show up in CMSSW_7_6_X_2015-08-30-2300 in unrelated places as migrate L1 and HLT summary modules to one::EDAnalyzer #11053 . I'm running valgrind to find the origin.
• tested locally in CMSSW_7_6_X_2015-08-30-2300 /test area sign581/: the same modules are executed in the same order in this PR and in the baseline

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1