Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix clang static analyzer warning using namespace in header #11020

Merged
merged 1 commit into from Aug 30, 2015
Merged

fix clang static analyzer warning using namespace in header #11020

merged 1 commit into from Aug 30, 2015

Conversation

gartung
Copy link
Member

@gartung gartung commented Aug 28, 2015

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_6_X.

fix clang static analyzer warning using namespace in header

It involves the following packages:

RecoJets/JetProducers

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @ahinzmann, @TaiSakuma, @yslai, @nhanvtran, @schoef, @mariadalfonso this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@gartung
Copy link
Member Author

gartung commented Aug 28, 2015

@Dr15Jones

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@slava77
Copy link
Contributor

slava77 commented Aug 28, 2015

a combined PR with other similar ones (at least by L2 area) would be nicer.
Less load on jenkins and faster to approve.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #11020 2447b59

Fixing namespace warnings in jet pile-up header file. There should be no change in run-time behavior.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_6_X_2015-08-28-1100 show no significant differences, as expected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Aug 30, 2015
…g-warning

fix clang static analyzer warning using namespace in header
@cmsbuild cmsbuild merged commit ed883d8 into cms-sw:CMSSW_7_6_X Aug 30, 2015
@gartung gartung deleted the RecoJets-JetProducers-fix-clang-warning branch September 1, 2015 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants