Vertex and tracking DQM: fix histo scales, add ngood vertex, Add valid,lost,missing inner/outer hits 2d-histos #11044
Conversation
VinInn
changed the title
|
A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_7_6_X. Vertex and tracking DQM: fix histo scales, add ngood vertex, Add valid,lost,missing inner/outer hits 2d-histos It involves the following packages: DQM/TrackingMonitor @cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks. |
use a more sensible scale
|
Pull request #11044 was updated. @cmsbuild, @danduggan, @deguio can you please check and sign again. |
|
@cmsbuild please test |
|
please test |
|
The tests are being triggered in jenkins. |
|
-1 runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step3_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log 4.53 step3 runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log 140.53 step2 runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log 25.0 step5 runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step5_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log 1000.0 step2 runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log 1001.0 step2 runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3.log you can see the results of the tests here: |
|
segfault in Cling? |
|
Looks like it, or it could it JIT'ed function. Maybe building a debug build of ROOT (incl. internal LLVM) could help with stack traces. |
|
I tried it on DEVEL_X IBs (ROOT 6.04.XX): |
|
looks a real issue. |
|
Looks like My guess is that Uhh Could we get all of these as |
| @@ -136,6 +136,21 @@ class TrackAnalyzer | |||
| , NumberOfValidRecHitsPerTrackVsEta(NULL) | |||
| , NumberOfValidRecHitVsPhiVsEtaPerTrack(NULL) | |||
|
|
|||
| , NumberOfLostRecHitsPerTrackVsPhi(NULL) | |||
There was a problem hiding this comment.
Could we drop all of these and just set to nullptr at the declaration place? Otherwise you end up managing two different lists which are out-of-sync (e.g., xPointOfClosestApproachToPV isn't set to nullptr. This also isn't consistent they way it's done now. I would prefer a commit making a proper cleanup of this.
There was a problem hiding this comment.
me too.
will try.
Still I am almost sure this is not the problem...
maybe is
if(doDCAPlots_ || doPVPlots_ || doSIPPlots_ || doAllPlots_) {
while the booking is only
if(doDCAPlots_ || || doAllPlots_) {
There was a problem hiding this comment.
Correct, but it could reveal more issues (e.g., it did happen in Pythia8, because they kept checking garbage pointers in if-statements).
I see, some members are set to nullptr is TrackAnalyzer::initHistos(). So there are 3 different places there it's being done.
It seems that doDCAPlots_ must be true.
(gdb) info b
Num Type Disp Enb Address What
1 breakpoint keep y 0x00007fffbf4dfa0f in TrackAnalyzer::bookHistosForHitProperties(DQMStore::IBooker&) at /data/davidlt/fix_root/CMSSW_7_6_DEVEL_X_2015-09-01-2300/src/DQM/TrackingMonitor/src/TrackAnalyzer.cc:411
410 histname = "xPointOfClosestApproachToPV_";
411 xPointOfClosestApproachToPV = ibooker.book1D(histname+CategoryName, histname+CategoryName, VXBin, VXMin, VXMax);
412 xPointOfClosestApproachToPV->setAxisTitle("x component of Track PCA to pv (cm)",1);
413 xPointOfClosestApproachToPV->setAxisTitle("Number of Tracks",2);
So, I guess doDCAPlots_ isn't true. Breakpoint didn't hit it.
There was a problem hiding this comment.
Confirmed, the configuration file has doDCAPlots as False.
(gdb) p doDCAPlots_
$1 = false
fix booking protection
|
please test |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
CMSSW_7_6_0_pre5 is out Can I ask to motivate this state of the affairs? |
|
Was there a change in the CMSSW_7_6_0 schedule? I did not see any updates at https://twiki.cern.ch/twiki/bin/viewauth/CMS/CMSSW_7_6_0 but I also see that CMSSW_7_6_0_pre5 was tagged 4 days ago. On the BTV side, we still have a few open PRs that will affect RECO so I'm a bit confused about whether pre5 was really the last open pre-release or that is now postponed to pre6. |
|
we are going to have an ORP meeting in 8 minutes. I believe this will be clarified there. |
|
please test |
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
+1 |
Vertex and tracking DQM: fix histo scales, add ngood vertex, Add valid,lost,missing inner/outer hits 2d-histos
forward port of #11027 and #11026