Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fastsim ECAL response correction (2) #11045

Merged
merged 21 commits into from Sep 2, 2015
Merged

Fastsim ECAL response correction (2) #11045

merged 21 commits into from Sep 2, 2015

Conversation

kkiesel
Copy link
Contributor

@kkiesel kkiesel commented Aug 31, 2015

Rebase of this pull request:
#10596
The correction is disabled by default

Knut Kiesel added 20 commits August 31, 2015 16:40
Application of the ecal responce correction in fastsim
9514b27 
The histogram is read in, and for each particle the
correct scale is searched and applied.
Changing default behaviour for ecal scaling to FALSE
d007c81
variable binning in energy
0d5a9bf
moved parametes to seperate python config file
16ab48f
Moved correction to sperate class, which is called in the
f62781d 
CalorimetryManager
removing TH3F incude
36b8b86
Removed one function from CaloResponse class
30bbe10 
The functionality is moved to the CalorimetryManager.
Renamed CaloResponse to KKCorrectionFactors
eb5d9c2
adding scaling method
fe09c28
changed variable names for filename and histogramName
f2dc727
using 'TFile::Open' instead of the TFile constructor
bfb8dc0
replacing axis->GetBinLowEdge(..) with axis->GetXmin/GetXmax()
d6f91b6
see no need to close here before deleting
9be47c5
renaming interpolation option to make clear that an interpolation in …
77d086a 
…3d is done
deleting default option 'READ' for TFile
c7d4801
empty bins are not filled with 1
82c09bf
using unique_ptr
a2731fb
generalizing exception message
b91137f
using former method of 1d interpolation, and not the TH3F::Projection…
3cc5335 
… method
The method to calculate the scale factors is now invoked by python
e018482
@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Aug 31, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kkiesel (Knut Kiesel) for CMSSW_7_6_X.

Fastsim ECAL response correction (2)

It involves the following packages:

FastSimulation/Calorimetry

@cmsbuild, @ssekmen, @civanch, @mdhildreth, @lveldere can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

Pull request #11045 was updated. @cmsbuild, @ssekmen, @civanch, @mdhildreth, @lveldere can you please check and sign again.

@lveldere
Copy link
Contributor

lveldere commented Sep 1, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2015

+1
Tested at: 22043db
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11045/7774/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11045/7774/summary.html

@lveldere
Copy link
Contributor

lveldere commented Sep 1, 2015

+1

@kkiesel
Could you add to the description (1st comment)
that the corrections are by default not switched on?

Thanks

Lukas

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 2, 2015
@cmsbuild
Merge pull request #11045 from kkiesel/fastsimECALresponseCorrection76X
bba7104 
Fastsim ECAL response correction (2)
@cmsbuild cmsbuild merged commit bba7104 into cms-sw:CMSSW_7_6_X Sep 2, 2015
@kkiesel kkiesel mentioned this pull request Sep 2, 2015
Closed
@silviodonato silviodonato mentioned this pull request Feb 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fastsim-approved fully-signed tests-approved
Projects
None yet
Milestone
CMSSW_7_6_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kkiesel @cmsbuild @lveldere @davidlange6