ngrenz: small optimization of Monitor Track inside the DQM

[ngrenz]

Work intended to optimize the performance of tracker validation code and code cleanup.

Changes:

• Combination of functions fillModMEs() and fillMEs() with clusterInfos() --> reduce code repetition
• use strstr() instead of find()
• prefer prefix
• inline of some book functions
• put unused code inside a comment

Outputs are supposed to be unchanged.
Any comments and suggestions are welcome.

[ngrenz]

@boudoul FYI

[cmsbuild]

A new Pull Request was created by @ngrenz for CMSSW_7_6_X.

ngrenz: small optimization of Monitor Track inside the DQM

It involves the following packages:

DQM/SiStripMonitorTrack

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
@threus this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[deguio]

please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

Pull request #11059 was updated. @cmsbuild, @danduggan, @deguio can you please check and sign again.

[cmsbuild]

+1
Tested at: dff5cc2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11059/8041/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11059/8041/summary.html

[deguio]

+1
no regression observed.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1