Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Appy event filter before data prefetching for OutputModules #11092

Merged
merged 5 commits into from Sep 4, 2015
Merged

Appy event filter before data prefetching for OutputModules #11092

merged 5 commits into from Sep 4, 2015

Commits on Sep 2, 2015

  1. Removed unused stream::OutputModuleBase::getTriggerResults 

    The method isn't used and the present signature does not allow for consumes.
If it becomes necessary to return this functionality, it should be done by adding a
stand alone function which is passed an EDGetTokenT<TriggerResults>.
The legacy OutputModule uses a modified version of this to support
StreamerOutputModuleBase.
    @Dr15Jones
    Dr15Jones committed Sep 2, 2015
    Configuration menu
    Copy the full SHA
    b5886f0 View commit details
    Browse the repository at this point in the history

  2. Made OutputModule::getTriggerResults be compatible with consumes 

    The previous API for getTriggerResults would allow one to retrieve the results without having to first declare consumes. The new interface requires an EDGetTokenT<TriggerResults>. The implementation of this function also avoids coupling with the event selector code. This allowed those interfaces to be removed from TriggerResultsBasedEventSelector.
    @Dr15Jones
    Dr15Jones committed Sep 2, 2015
    Configuration menu
    Copy the full SHA
    113b50c View commit details
    Browse the repository at this point in the history

  3. Use an event selector per Stream 

    In order to allow event selection checking to run in parallel, we needed a TriggerResultsBasedEventSelector per stream.
    @Dr15Jones
    Dr15Jones committed Sep 2, 2015
    Configuration menu
    Copy the full SHA
    f13d41a View commit details
    Browse the repository at this point in the history

  4. Use properly initialized StreamID for test 

    Changes to the implementation of the OutputModule now require a properly initialized StreamID when calling the Event method.
    @Dr15Jones
    Dr15Jones committed Sep 2, 2015
    Configuration menu
    Copy the full SHA
    73b8f04 View commit details
    Browse the repository at this point in the history

  5. Test for rejection of event from TriggerResults in OutputModule befor… 

    …e prefetching data

There is no reason to prefetch data and subsequently causing either delayed read or unscheduled execution if the TriggerResults being watched designate that the event should not be stored.
    @Dr15Jones
    Dr15Jones committed Sep 2, 2015
    Configuration menu
    Copy the full SHA
    c38f696 View commit details
    Browse the repository at this point in the history