Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward originalAlgo and algoMask in TrackRefitter #11112

Merged
merged 2 commits into from Sep 5, 2015

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Sep 3, 2015

This PR adds forwarding of originalAlgo and algoMask for TrackRefitter to the TrackProducerAlgorithm. The PR also includes minor cleanup of unnecessary members in TrackProducerAlgorithm.

Tested in 760pre4, no changes in RECO expected.

@rovere @VinInn

@slava77
Copy link
Contributor

slava77 commented Sep 3, 2015

@smuzaffar @Degano
please check the bot status.
There are no signature labels or a summary message yet after 20 minutes from submission

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2015

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_6_X.

Forward originalAlgo and algoMask in TrackRefitter

It involves the following packages:

RecoTracker/TrackProducer

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @istaslis, @gpetruc, @cerati, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Sep 3, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2015

The tests are being triggered in jenkins.

@smuzaffar
Copy link
Contributor

@slava77 , we had to restart jenkins as it hit max heap size and was not able to connect to any slave.
It should be in better state now

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2015

I have re-started the tests
The jenkins tests job failed, please try again.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/7875/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2015

@cvuosalo
Copy link
Contributor

cvuosalo commented Sep 4, 2015

+1

For #11112 8edb477

Minor technical fix for the TrackProducerAlgorithm. It should not cause any change in monitored quantities.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_6_X_2015-09-03-1100 show no significant differences, as expected.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 5, 2015
Forward originalAlgo and algoMask in TrackRefitter
@cmsbuild cmsbuild merged commit 481d711 into cms-sw:CMSSW_7_6_X Sep 5, 2015
@makortel makortel deleted the refitterForwardAlgo branch October 20, 2016 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants