Static analysis warnings fixes

[civanch]

It is the same PR as 11097

[davidlt]

@civanch this also fixed G4 related segfaults in DEVEL IBs?

@davidlange6

[cmsbuild]

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_7_6_ROOT64_X.

Static analysis warnings fixes

It involves the following packages:

SimCalorimetry/EcalSelectiveReadoutAlgos
SimG4CMS/Calo
SimG4CMS/FP420
SimG4CMS/Forward
SimG4CMS/HcalTestBeam
SimG4Core/Application
SimG4Core/CustomPhysics
SimG4Core/PhysicsLists
SimMuon/RPCDigitizer
SimTracker/Common
SimTracker/SiStripDigitizer

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@jlagram, @makortel, @GiacomoSguazzoni, @gbenelli, @rovere, @argiro, @cnuttens, @prolay, @jhgoh, @cerati, @VinInn, @threus, @dgulhan, @LBeck this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

[civanch]

@davidlt , yes, it should fix few IB crashes. Not for the first time static analysis helps.

[civanch]

please test

[civanch]

+1

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_ROOT64_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_ROOT64_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests.

[davidlt]

Let's put it in and see if it resolves the issues.

[davidlt]

@davidlange6 @civanch do we need this in CMSSW_8_0_X? Is this just static analyzer cleanups?

[civanch]

@davidlt, it is written that this PR is the same as #11097, which has been integrated in 7_6_X, likely these fixes are in 8_0_X already. However, there are still a lot of static analysis complains in 8_0_X for SIM and I plan to reduce them in coming weeks.