New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix conversion to XML for objects with template names #11120
Conversation
apfeiffer1
commented
Sep 4, 2015
- fix conversion to XML for objects with template names
- add an example for conversion of EcalCondObjectContainer objects to XML in C++ to speed up conversion (1 sec instead of 20 sec when compiled-on-the-fly)
…tatusCode> objects to XML in C++ to speed up
A new Pull Request was created by @apfeiffer1 (Andreas Pfeiffer) for CMSSW_7_6_X. fix conversion to XML for objects with template names It involves the following packages: CondCore/CondDB @ggovi, @cmsbuild can you please review it and eventually sign? Thanks. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
@apfeiffer1 - this does not merge - could you rebase it. Thanks |
@cmsbuild please test again |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
@davidlange6 - ping ... is there a reason this is not in yet ? |
its not tested yet - I'll start those |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
-1 Tested at: 612d4ac /bin/sh: -c: line 0: you can see the results of the tests here: |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
Could some expert please "translate" to me the error message ? Sorry, but I do not understand either the text in the comments here nor the one at the link :( My present understanding is that the line (from the link): /bin/sh: -c: line 0: syntax error near unexpected token `(' indicates a problem in the infrastructure, not really a problem of the unit-test itself (which should not be affected by the changes in the PR at all) ??? Thanks, |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
fix conversion to XML for objects with template names
How did this pass? This is breaking unit test compilation.
You removed testCondDBDict library, but did not remove statements in 3 unit test linking to it. |
Apparently testRootStreaming test requires you to have a dictionary built in test. |