Made MaterialAccountingTrack const correct

[Dr15Jones]

MaterialAccountingTrack had exposed its member data as public and had
two mutable data members. This change puts the code in line with CMSSW
standards for data products.

This problem was found by the static analyzer.

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_6_X.

Made MaterialAccountingTrack const correct

It involves the following packages:

SimDataFormats/ValidationFormats
SimTracker/TrackerMaterialAnalysis

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @rovere, @VinInn, @cerati, @threus, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

-1
Tested at: 5a2be8e
I found an error when building:

>> Compiling edm plugin /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-03-2300/src/SimMuon/RPCDigitizer/src/RPCSynchronizer.cc 
>> Compiling edm plugin /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-03-2300/src/SimMuon/RPCDigitizer/src/SealModule.cc 
>> Compiling edm plugin /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-03-2300/src/GeneratorInterface/EvtGenInterface/plugins/EvtGenUserModels/EvtLb2plnuLCSRFF.cpp 
>> Compiling edm plugin /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-03-2300/src/GeneratorInterface/EvtGenInterface/plugins/EvtGenUserModels/EvtLb2plnuLCSR.cpp 
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-03-2300/src/GeneratorInterface/EvtGenInterface/plugins/EvtGenUserModels/EvtLb2plnuLCSRFF.cpp: In member function 'virtual void EvtLb2plnuLCSRFF::getdiracff(EvtId, EvtId, double, double, double_, double_, double_, double_, double_, double_)':
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-03-2300/src/GeneratorInterface/EvtGenInterface/plugins/EvtGenUserModels/EvtLb2plnuLCSRFF.cpp:87:16: error: 'EVTGEN_ERROR' was not declared in this scope
   EvtGenReport(EVTGEN_ERROR,"EvtGen") << "Only Lb -> p transitions allowed in EvtLb2plnuLCSRFF.\n";  
                ^
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-03-2300/src/GeneratorInterface/EvtGenInterface/plugins/EvtGenUserModels/EvtLb2plnuLCSRFF.cpp:87:37: error: 'EvtGenReport' was not declared in this scope
   EvtGenReport(EVTGEN_ERROR,"EvtGen") << "Only Lb -> p transitions allowed in EvtLb2plnuLCSRFF.\n";  
                                     ^


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11135/7897/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
e042f6d
e4f8c6d
96f5231
0694993
3ebbeec
e739969
45d6fa0
57c324c
0d9bb37
2908a4e
c506ce7
8247b6c
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11135/7897/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11135/7897/git-merge-result

[Dr15Jones]

This error is not from this pull request and is in the IB.

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: 5a2be8e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11135/7961/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11135/7961/summary.html