Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSC Beam Halo filter update #11137

Merged
merged 8 commits into from Oct 21, 2015
Merged

Conversation

lathomas
Copy link
Contributor

@lathomas lathomas commented Sep 4, 2015

(Copy of the PR for 74X)
CSC Beam Halo Filter update.
-Pairs of segments in opposite endcaps are now matched with a dr/dz condition (rather than dr previously)
-New flat CSC segment matching added (the old one remains the default for now): unvetoing CSC segments associated to tracker muons with pt < 3 gev
-Optional dt matching of opposite endcaps segments
-Testing a CSC segment/calorechit matching.
-Two new working points added in BeamHaloSummary.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2015

A new Pull Request was created by @lathomas for CMSSW_7_5_X.

CSC Beam Halo filter update

It involves the following packages:

DataFormats/METReco
RecoMET/METAlgorithms
RecoMET/METProducers

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @ahinzmann, @mmarionncern, @jdolen, @nhanvtran, @schoef, @mariadalfonso, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Sep 4, 2015

@cmsbuild please test

@lathomas please make a PR for 76X

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2015

Pull request #11137 was updated. @cmsbuild, @cvuosalo, @slava77 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2015

@lathomas
Copy link
Contributor Author

I will try to male the PR for 76X today. In the mean time, is it already possible to integrate this PR to 75X as it was done for 74X?
Thanks a lot

@cmsbuild
Copy link
Contributor

Pull request #11137 was updated. @cmsbuild, @cvuosalo, @slava77 can you please check and sign again.

@cvuosalo
Copy link
Contributor

@cmsbuild please test

…e rate, only consider out of time hits in the calo-csc matching)
@lathomas
Copy link
Contributor Author

Copy of the following PR for 75X:
#11737

@cmsbuild
Copy link
Contributor

Pull request #11137 was updated. @cmsbuild, @cvuosalo, @vadler, @monttj, @slava77 can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Oct 13, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8773/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #11137 0c4a36b

Third approval of this PR for new, small adjustments to the CSC beam halo filter that come from 76X #11737, which has already been approved by Reco. #11136 is the matching PR to this one for 74X.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-10-12-2300 show no significant differences. An additional test of workflow 25202.0_TTbar_13 was done for #11737, and it showed no significant differences.

davidlange6 added a commit that referenced this pull request Oct 21, 2015
@davidlange6 davidlange6 merged commit 871650f into cms-sw:CMSSW_7_5_X Oct 21, 2015
@lathomas lathomas deleted the CMSSW_7_5_X branch November 14, 2018 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants