Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix premature end of run in DAQ (74X) #11156

Merged
merged 1 commit into from Sep 16, 2015

Conversation

smorovic
Copy link
Contributor

@smorovic smorovic commented Sep 5, 2015

In case of multiple pending lumisections in builder unit (ramdisk), recently forced behavior is to cycle the framework through each LS (previously source was skipping to the last one having raw data that needs to be processed). This change uncovered a loophole in logic allowing run to end prematurely if end of run file (written by BU) is in ramdisk, and there are still at least two empty lumisections followed by a LS with some raw data to process.
Fix is to allow the run to be closed only if no new files/lumisections have been discovered by source after EoR file has already been written to the input directory.

…ext LS is signalled to input source

*correct initialization of variable ls
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2015

A new Pull Request was created by @smorovic (Srecko Morovic) for CMSSW_7_4_X.

Fix premature end of run in DAQ (74X)

It involves the following packages:

EventFilter/Utilities

@mommsen, @cvuosalo, @cmsbuild, @emeschi, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@smorovic
Copy link
Contributor Author

smorovic commented Sep 6, 2015

@cmsbuild please test

@davidlange6
Copy link
Contributor

please test

On Sep 6, 2015, at 10:22 AM, Srecko Morovic <notifications@github.commailto:notifications@github.com> wrote:

@cmsbuildhttps://github.com/cmsbuild please test


Reply to this email directly or view it on GitHubhttps://github.com//pull/11156#issuecomment-138052001.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2015

@cvuosalo
Copy link
Contributor

cvuosalo commented Sep 9, 2015

+1

For #11156 6283f73

Bug fix related to lumi sections. There should be no change in monitored quantities.

The code change is satisfactory, and Jenkins tests against baseline CMSSW_7_4_X_2015-09-05-2300 show no significant differences, as expected.

@emeschi
Copy link
Contributor

emeschi commented Sep 14, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 16, 2015
Fix premature end of run in DAQ (74X)
@cmsbuild cmsbuild merged commit 28b8d24 into cms-sw:CMSSW_7_4_X Sep 16, 2015
@smorovic smorovic deleted the CMSSW_7_4_X-eorfix branch November 13, 2015 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants