Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

76x Fireworks: auto-detect configuration after opening first file -- git reattempt 2 #11167

Merged
merged 4 commits into from Sep 7, 2015
Merged

76x Fireworks: auto-detect configuration after opening first file -- git reattempt 2 #11167

merged 4 commits into from Sep 7, 2015

Conversation

alja
Copy link
Contributor

@alja alja commented Sep 6, 2015

This is forward port of #11055

@alja
Add case to init without a configuration. Set main window size simila…
647572c 
…r to pre-existing configurations.
@alja
Remove the case when there is an explicit empty configuration. Alread…
544fdaf 
…y handled in CmsShowMain.
@alja
Autodetect configuration after setup in case config file name is not …
9949cf6 
…give command line and file is loaded first stime,

Conflicts:
	Fireworks/Core/src/CmsShowMain.cc

Conflicts:
	Fireworks/Core/src/CmsShowMain.cc
@alja
Merge fixes.
108b7cd
@alja
Copy link
Contributor Author

alja commented Sep 6, 2015

+1

@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Sep 6, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2015

A new Pull Request was created by @alja (Alja Mrak-Tadel) for CMSSW_7_6_X.

75x Fireworks: auto-detect configuration after opening first file -- git reattempt 2

It involves the following packages:

Fireworks/Core

@cmsbuild can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlange6
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2015

+1
Tested at: 108b7cd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11167/7917/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

On Sep 7, 2015, at 8:56 AM, cmsbuild notifications@github.com wrote:

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

—
Reply to this email directly or view it on GitHub.

cmsbuild added a commit that referenced this pull request Sep 7, 2015
@cmsbuild
Merge pull request #11167 from alja/from-CMSSW_7_5_0
4d989e1 
75x Fireworks: auto-detect configuration after opening first file -- git reattempt 2
@cmsbuild cmsbuild merged commit 4d989e1 into cms-sw:CMSSW_7_6_X Sep 7, 2015
@alja alja mentioned this pull request Nov 6, 2015
Merged
@alja alja changed the title 75x Fireworks: auto-detect configuration after opening first file -- git reattempt 2 76x Fireworks: auto-detect configuration after opening first file -- git reattempt 2 Nov 6, 2015
@alja
Copy link
Contributor Author

alja commented Nov 6, 2015

I intended to shedule this PR for 75, but accidentally put it to 7_6_X branch.

@alja alja deleted the from-CMSSW_7_5_0 branch May 11, 2017 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending fully-signed tests-approved visualization-approved
Projects
None yet
Milestone
CMSSW_7_6_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alja @cmsbuild @davidlange6